fix: use CPU-aware prover scheduler - #897
Draft
jotabulacios wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
/bench |
Benchmark — real block (
|
| Metric | main | PR | Δ |
|---|---|---|---|
| Peak heap | 48519 MB | 53151 MB | +4632 MB (+9.5%) 🔴 |
| Prove time | 166.381s | 146.118s | -20.263s (-12.2%) 🟢 |
🎉 Improvement on the real block — prove time down 12.2%.
Prove-time spread 1.6% (147.254s / 146.118s / 144.936s)
Commit: 62301c8 · Baseline: cached · Runner: self-hosted bench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the CPU proving regression introduced by the table scheduler.
The GPU scheduler uses external driver threads to admit and overlap table work. On CPU, that caused table tasks to launch nested Rayon work from outside the Rayon pool, leading to oversubscription, cache contention, and memory-bandwidth contention.
The CPU path now:
The CUDA path and proof format are unchanged.