In the repo, we can see 2 different versions of Protobuf.
4.22.5 (aka 22.5, aka 4022005), in contrib/libs/protobuf, probably not used?
|
#define GOOGLE_PROTOBUF_VERSION 4022005 |
The same here:
4.22.5 (aka 22.5, aka 4022005) in contrib/libs/protoc
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/contrib/libs/protoc/src/google/protobuf/compiler/plugin.pb.h#L18C5-L18C12
The same recommendation is in the BUILD.md
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/BUILD.md?plain=1#L47
However, before the build, another version is installed by Conan:
3.21.12 (aka 21.12, 3021012)
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/conanfile.py#L21
From what I can see, there is no 4.22.* in the Conan repo. It's probably worth either removing the Conan version completely or bumping versions everywhere.
When different versions meet at compile- or run-time, we may (and do) see unwanted artefacts - sometimes code doesn't compile, sometimes we can face various crashes.
In the repo, we can see 2 different versions of Protobuf.
4.22.5 (aka 22.5, aka 4022005), in
contrib/libs/protobuf, probably not used?ytsaurus-cpp-sdk/contrib/libs/protobuf/src/google/protobuf/stubs/common.h
Line 81 in 8ad256c
The same here:
4.22.5 (aka 22.5, aka 4022005) in
contrib/libs/protochttps://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/contrib/libs/protoc/src/google/protobuf/compiler/plugin.pb.h#L18C5-L18C12
The same recommendation is in the
BUILD.mdhttps://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/BUILD.md?plain=1#L47
However, before the build, another version is installed by Conan:
3.21.12 (aka 21.12, 3021012)
https://github.com/ytsaurus/ytsaurus-cpp-sdk/blob/main/conanfile.py#L21
From what I can see, there is no
4.22.*in the Conan repo. It's probably worth either removing the Conan version completely or bumping versions everywhere.When different versions meet at compile- or run-time, we may (and do) see unwanted artefacts - sometimes code doesn't compile, sometimes we can face various crashes.