fix(hpack): validate decoder state across header blocks - #103
Merged
Merged
Conversation
Track the required lowest and final limits across complete field blocks, preserve dynamic-table synchronization for invalid fields, and report HPACK failures as connection compression errors.
0x676e67
changed the title
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The protocol-state and error-precedence changes warrant final human validation despite strong regression coverage.
Pull request overview
Strengthens HPACK decoder state validation while preserving compression context across malformed header blocks.
Changes:
- Tracks table-size updates across fragmented header blocks.
- Drains malformed blocks while retaining dynamic-table synchronization.
- Adds comprehensive decoder-state and sensitivity tests.
File summaries
| File | Description |
|---|---|
tests/h2-tests/tests/hpack_decoder_state.rs |
Adds HPACK state regression tests. |
tests/h2-support/src/mock.rs |
Applies peer table-size settings in test handshakes. |
src/hpack/mod.rs |
Exposes decoded-header metadata internally. |
src/hpack/decoder.rs |
Implements block-level decoder and malformed-entry state. |
src/frame/headers.rs |
Tracks malformed fields and decoded list size. |
src/codec/framed_read.rs |
Validates complete HPACK blocks and maps errors appropriately. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.