Repository navigation
eth: deflake TestSendTx - #2471
Open
aristide-bayard wants to merge 1 commit into
Open
aristide-bayard wants to merge 1 commit into
aristide-bayard wants to merge 1 commit into
Conversation
aristide-bayard
marked this pull request as ready for review
October 2, 2026 07:59
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
aristide-bayard
force-pushed
the
aristide-bayard/deflake-sendtx-adoption-tests
branch
from
October 15, 2026 12:36
d953c57 to
9a11269
Compare
Author
|
Hi @pratikspatil024, could you take a look at this one when you get a chance? It's rebased on the latest |
Member
|
Hey, please raise it against develop. |
TestSendTx races against background work and fails under CPU starvation (reproduced locally by pinning the test to a core shared with a busy loop): SendTx adds to the pool with sync=false, so txA may still be queued when txB arrives. checkDelegationLimit then sees no pending list and returns the gapped-nonce error instead of the in-flight limit. Wait for txA to be promoted before sending txB.
aristide-bayard
force-pushed
the
aristide-bayard/deflake-sendtx-adoption-tests
branch
from
October 16, 2026 14:12
9a11269 to
1d61f1a
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
aristide-bayard
changed the title
Author
|
@pratikspatil024 done: rebased on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deflakes
TestSendTx(eth/api_backend_test.go), which races against background work and fails under CPU starvation (reproduced locally at 100% by pinning the test process to a single core shared with a busy loop).SendTxadds to the pool withsync=false, so txA may still be queued when txB arrives.checkDelegationLimitthen sees no pending list for the sender and returnsErrOutOfOrderTxFromDelegatedinstead ofErrInflightTxLimitReached. The test now waits for txA to be promoted before sending txB.Test-only change, no production code touched.
The
TestBuildStartDiscardsSupersededBufferpart of the original PR was dropped: #2492 (v2.10.3) already fixes that flake withwaitReadPath.Executed tests
Rollout notes
Not consensus-affecting, no operator-facing change. Retargeted to
developas requested. Commits are not GPG-signed (external contributor).