Repository navigation
ci: check the supported-minimum Expo build and fix docs - #91
Conversation
Add missing put import to the typed-data snippet, INTERNET permission note, package map, trails-actions and CI check notes, a 0.3.1 migration entry, and correct CI, API-docs, and layout descriptions for contributors.
Move with-local-kotlin-sdk.js to compatibility-tests/shared/ and resolve expo/config-plugins from the fixture being prebuilt, so each fixture uses its own Expo version.
Mirror the React Native SDK's supported minimum (expo 56.0.23, react-native 0.85.3, react 19.2.3) so Kotlin SDK changes that break it fail here. The check publishes to Maven Local once, then builds the current-stable fixture (still freshness-checked) and the minimum fixture (never freshness-checked), prebuilding the latter with the pinned SDK 56 template expo-template-bare-minimum@56.0.37 because expo 56.0.15+ bundles the SDK 57 template. CI caches npm for both lockfiles.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @tolgahan-arikan's task in 2m 13s —— View job PR Review: CI supported-minimum Expo build + docs fixes
Verdict: Looks good. This is a docs + CI + Expo-fixture change with no SDK source, build, or version edits — nothing touches wallet, signing, keystore, or session code, so there's no security-sensitive surface and no public API change. I verified the claims I could check locally. What I verified ✅
Nits (non-blocking)
No test-coverage concerns: there's no behavior change to cover, and the fixture is the test. ktlint/KDoc are N/A — no Kotlin changed. The one thing I can't verify locally is that the two |
Summary
Consumer and contributor documentation fixes, plus a supported-minimum Expo fixture in the Expo compatibility check. A Kotlin SDK change that breaks the React Native SDK's minimum (Expo SDK 56 / React Native 0.85) now fails here, before a release. No source, build, or version changes to the SDK itself.
Changes
Expo compatibility: current and supported minimum
compatibility-tests/expo-min/.tools/check-expo-compatibility.shcurrentorminimumto build one fixture, or builds both when run without an argument.expo-template-bare-minimum@56.0.37. Everyexpo56.x from 56.0.15 on ships the SDK 57 native template, so a plainexpo prebuildwould silently generate an Expo 57 project.compatibility-tests/shared/with-local-kotlin-sdk.jsand used by both fixtures. It loadsexpo/config-pluginsfrom the fixture being prebuilt.android-ci.yml)buildinto anexpo-compatmatrix job,currentandminimum, that runs in parallel withbuildon standard runners.--refresh-dependencies, which came from fix(build): restore stable Expo compatibility #87. Gradle readsmavenLocal()directly and never caches it, so the freshly published SDK is used without it. This machine's Gradle cache holds only the Maven Central releases of the SDK, never the-expo-compatbuilds. The flag only forced every remote dependency to be re-checked.GITHUB_TOKENtocontents: read. Only thebuildjob also getschecks: write, whichmikepenz/action-junit-reportneeds to publish the unit test report..github/workflows/claude-review.yml): both the automatic review and@claudereplies now use Claude Sonnet 5.5 (claude-sonnet-5-5) instead of Opus 4.8.expo,react, andreact-nativeare ignored, and patches are grouped.Docs
import kotlinx.serialization.json.put. It fails to compile without it (Argument type mismatch: String vs JsonElement).android.permission.INTERNETrequirement, since the SDK's manifest declares no permissions.trails-actionsmodule and CI's./gradlew --build-cache verifyplustools/check-expo-compatibility.sh.android-ci.yml, and passingcurrentorminimumbuilds a single Expo fixture locally. Also covers the Node 24 prerequisite, thegenerateApiDocs/checkApiDocs/public API baseline workflow, and what the Expo compatibility check covers.compatibility-tests/expo-min, and Kotlin toolchain or artifact metadata changes must pass both Expo fixtures.Testing
./gradlew ktlintCheckpasses (run byverify)./gradlew :oms-wallet-kotlin-sdk:testDebugUnitTestpasses (run byverify)./gradlew --build-cache verifypasses (BUILD SUCCESSFUL in 1m 39s)Instrumented tests: not applicableAlso:
tools/check-expo-compatibility.shpasses locally in each mode, without--refresh-dependenciesand with a warm cache.minimum: 98s, with the fixture build passing in 91s.current: 91s, with the fixture build passing in 89s.--refresh-dependencies, the fixture builds took 136s and 142s.com.facebook.react:react-android -> 0.85.3and the localio.github.0xsequence:oms-wallet-kotlin-sdk:0.3.1-expo-compatfrom Maven Local.dependabot.ymlandandroid-ci.ymlvalidate against their JSON schemas.Related
Part of one documentation pass across the OMS Wallet SDKs and docs site: