Skip to content

ci(release): bump every v2 package together via fixed versioning - #1042

Merged
taylanpince merged 2 commits into
v2from
ci/v2-fixed-versions
Oct 21, 2026
Merged

taylanpince merged 2 commits into
v2from
ci/v2-fixed-versions

Conversation

@taylanpince

Copy link
Copy Markdown
Contributor

Summary

Addresses the Codex finding on #1037: that release bumps only the packages reached by changesets (and their dependents) to 2.3.48, leaving @0xsequence/core and others at 2.3.47. Because update-version embeds core's version, VERSION (sent by the provider as clientVersion) would report 2.3.47 from a 2.3.48 provider, and the release would not match the PUBLISHING.md claim that every package is staged at one version.

  • .changeset/config.json: replace linked with fixed: [["@0xsequence/*", "0xsequence"]]. linked only aligns versions among packages already being bumped; fixed bumps the whole group on any changeset. The unscoped 0xsequence package is listed explicitly since the glob does not match it.
  • PUBLISHING.md: describe the fixed versioning accurately.
  • Empty changeset for the changeset check.

Test plan

  • pnpm changeset status --verbose on this branch lists all 25 packages (including @0xsequence/core) at 2.3.48.
  • After merge, the Changesets action should regenerate changesets: Release / Deploy (v2) #1037 with every package at 2.3.48 and VERSION = '2.3.48'.

🤖 Generated with Claude Code

@taylanpince
taylanpince requested a review from a team October 20, 2026 13:46
@taylanpince
taylanpince requested a review from a team as a code owner October 20, 2026 13:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T13:49:28.449733Z 7888803 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

`linked` only aligns versions among packages that are already being
bumped, so the 2.3.48 release left core and other untouched packages at
2.3.47. `update-version` reads core's version, so VERSION (sent by the
provider as clientVersion) would have stayed at 2.3.47 while the
provider shipped as 2.3.48. Switch to `fixed` and include the unscoped
`0xsequence` package so any changeset releases every package at one
version, as PUBLISHING.md describes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tolgahan-arikan

Copy link
Copy Markdown
Contributor

Switching to fixed looks right for future releases, but as written this PR won't realign the versions that are already split. The description assumes #1037 is still open. It was merged on 2026-10-20 at 13:50 UTC, and this branch (ef69784) sits directly on that merge commit (8b1fe9d).

Current state of v2:

  • 13 packages are at 2.3.48: 0xsequence, account, auth, guard, migration, network, provider, react-native, relayer, sessions, waas, waas-ethers, wallet.
  • 12 are still at 2.3.47: abi, api, builder, core, deployer, indexer, marketplace, metadata, replacer, signhub, tests, utils.
  • packages/core/src/version.ts is still VERSION = '2.3.47'.
  • Of the 2.3.48 packages, only @0xsequence/relayer@2.3.48 is on npm (v2-legacy). The Release run for 8b1fe9d failed with E401 while staging @0xsequence/network-2.3.48.tgz, so the other twelve were never staged.

What this PR does on that base (checked locally with @changesets/cli 2.27.9, the version in the lockfile):

  • pnpm changeset status --verbose says it would release no packages. fixed only spreads a bump that a changeset requests, and the only changeset here is empty.
  • changeset version only deletes .changeset/fixed-v2-versions.md, so the next release PR would contain just that deletion. When it merges, stage-npm-packages.mjs stages every unpublished, untagged version. That would be the remaining 2.3.48 packages, with core still at 2.3.47, which is the mismatch this PR is meant to fix.

Possible fix: replace the empty changeset with a real one, e.g. '@0xsequence/core': patch. On this branch with that change, changeset status bumps all 25 packages to 2.3.49 (the fixed group takes the highest current version, 2.3.48, and applies the patch). The other option is to set every package to 2.3.48 by hand and rerun pnpm update-version. Relayer 2.3.48 is already published, so the staging script would skip it.

Question: Which do you want: 2.3.49 for everything, or realign the rest to 2.3.48? The test plan's expectation (all packages at 2.3.48) only works with the second option.

Nit (PUBLISHING.md): "any changeset bumps every package" isn't true for empty changesets (pnpm changeset add --empty, recommended a few lines below), which bump nothing. Suggest "any non-empty changeset".

The empty changeset bumps nothing, so fixed versioning had no bump to
spread and the next release would stage the remaining 2.3.48 packages
with core and VERSION still at 2.3.47. A patch changeset for core makes
Changesets bump the whole fixed group to 2.3.49. Clarify in
PUBLISHING.md that only non-empty changesets bump the group.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@taylanpince
taylanpince merged commit 22375c8 into v2 Oct 21, 2026
26 checks passed
@taylanpince
taylanpince deleted the ci/v2-fixed-versions branch October 21, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants