Skip to content

fix(wallet-import): trust WaaS v1.1.1 enclave measurements - #48

Merged
taylanpince merged 1 commit into
masterfrom
update-waas-v1.1.1-pcr0
Oct 5, 2026
Merged

taylanpince merged 1 commit into
masterfrom
update-waas-v1.1.1-pcr0

Conversation

@tolgahan-arikan

@tolgahan-arikan tolgahan-arikan commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Trust the WaaS v1.1.1 enclave measurements for wallet import, and prepare release 0.3.1.

Environment Before After
Staging e271fe4b… 3d21c705… (v1.1.1 next)
Production 1935cbc7… (v1.1.0) 1935cbc7… + 66d0d200… (v1.1.1)

Measurements are from the WaaS v1.1.1 release:

  • Staging already runs v1.1.1, so wallet import fails there until this ships.
  • Production keeps v1.1.0 trusted until its rollout finishes. Remove 1935cbc7… in a follow-up.

Verification: live staging attestations pass the SDK verifier with the new PCR0. Rebuilding v1.1.1 from source reproduces the release's production PCR0s.

Testing

  • scripts/verify.sh

Related

Replace the retired Staging PCR0 with the v1.1.1 next build and trust the
v1.1.1 Production PCR0 alongside v1.1.0 ahead of the Production rollout.
Prepare release 0.3.1.
@tolgahan-arikan
tolgahan-arikan requested a review from a team October 5, 2026 11:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T11:28:27.329931Z 260c7ef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Claude finished @tolgahan-arikan's task in 13s —— View job


Review of PR #48

No blocking issues found. I read the diff but did not run swift test or scripts/verify.sh. The PR description reports both passing.

What I checked

  • PublishableKey.swift
    • Staging swaps the retired e271fe4b… for 3d21c705….
    • Production keeps v1.1.0 (1935cbc7…) and adds v1.1.1 (66d0d200…).
    • Both values are 96 hex characters, as a SHA-384 PCR0 should be.
    • This matches the rotation comment above the sets, which asks the SDK to trust both measurements before a deploy.
  • Tests
    • The route table now compares the full trusted set per environment, so an accidental drop of v1.1.0 from production would fail.
    • The staging and production literals in the tests match the source.
  • Release 0.3.1
    • The podspec s.version and the three README snippets (SPM UI, Package.swift, CocoaPods) are consistent.
    • No public API change, so leaving API.md and MIGRATION.md alone is correct.
  • AGENTS.md conventions
    • No private-key or session-storage changes.
    • No token-amount math.
    • No new public surfaces, so no @available annotations are needed.
    • No shell examples with paths to quote.

Non-blocking suggestions

  1. Production now trusts the old v1.1.0 measurement alongside the new one. Open a tracked follow-up to remove 1935cbc7… once the rollout finishes. Otherwise that PCR0 stays trusted indefinitely.
  2. The tests don't cover a retired measurement being rejected. For example, you could assert that e271fe4b… is not in the staging set. The exact-set equality already implies this, so it's optional.
  3. After merge, tag 0.3.1 per publishing.md. Also check that nothing else hardcodes 0.3.0, for example the demo apps or a version-alignment check. The description says scripts/verify.sh passed, which includes version alignment.

Looks good to merge once CI is green.

@taylanpince
taylanpince merged commit c8e5f5b into master Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants