fix: align generation activity tooltip and localization - #44
Open
morehardy wants to merge 1 commit into
Open
Conversation
morehardy
marked this pull request as ready for review
August 5, 2026 15:08
morehardy
force-pushed
the
codex/fix-generation-activity-tooltip-i18n
branch
from
August 5, 2026 23:18
7681800 to
ec41a84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titletooltip with the same immediate tooltip and hover treatment used by the other top-bar action iconsTBtnimplementation into a sharedTopBarIconButton, including badge support for active generation jobspretestWhy
The Generation Activity icon was implemented separately from the adjacent top-bar controls. It used the browser-native
titletooltip and had no matching foreground/background hover feedback, so its interaction looked and behaved differently.The component called
t()for some labels, but the English dictionary did not contain those keys. Several helper paths also returned hard-coded Chinese strings, including relative timestamps and legacy job summaries. As a result, switching the UI to English still showed Chinese text.Implementation
TopBarIconButtonas the single implementation for right-side top-bar icon actionsTopBarandGenerationActivity, while preserving the active-job count badgenormalizeStatus()helper before displaying localized labelstitle, contains all required English keys, and formats relative time through i18nUser impact
The Generation Activity icon now has the same immediate tooltip and hover feedback as adjacent actions. The task panel displays consistent Chinese or English copy after changing the interface language, without changing persisted job data or job lifecycle behavior.
Validation
npm run verify:toolbar-tooltips— passednpm run lint— passedgit diff --check— passedmainat94f1ba9; GitHub reports the PR as mergeable with no conflictsnpm run build— currently blocked by an upstream type error outside this PR:firstChunkMsis not present in the declared timing type used bysrc/agent/api-runtime.tsnpm test— all checks reached beforesrc/media/mobileImport.verify.tspassed; the suite then stopped because the installedheic-to/cspmodule does not export the requestedheicTosymbol. The affected file is unchanged by this PR.