fix(quick-start): disable prompt autocomplete - #553
Open
huyanxius wants to merge 2 commits into
Open
Conversation
Browser form history can obscure the creation composer. Assert autocomplete is disabled on the prompt field and form. Protect the conversational input contract from regressions.
Saved form entries appear over the conversational creation composer. Disable autocomplete on both the prompt field and its form. Keep browser history suggestions out without changing generation behavior.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
审查结论
变更在 Quick Start 的创作指令表单和输入框上同时声明 autocomplete="off"，与 #552 的浏览器历史补全契约一致；定向测试覆盖了两个 DOM 属性，未发现会影响原有输入、提交或母版上传流程的可报告问题。
验证
npm test -- src/pages/quick-start/index.test.tsx --configLoader runner -t 'keeps browser form history'：1 passednpx oxfmt --check src/pages/quick-start/index.tsx src/pages/quick-start/index.test.tsx：通过git diff --check 17b25a723410244d9f0a68209d3c946ca0698b56...f561d2af82fbef8a1f2b55bb0f14e23b4fdc7c84：通过
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 Quick Start 创作指令输入框被浏览器识别为普通历史表单的问题，避免历史角色描述建议遮挡创作界面。
Why
当前输入框与所属表单未声明自动补全策略，浏览器会在聚焦时弹出历史表单内容；对话式创作输入不应复用这类建议。
Changes
autocomplete。Verification
npm test -- src/pages/quick-start/index.test.tsx --configLoader runner -t 'keeps browser form history'：1 passed。oxfmt --check src/pages/quick-start/index.tsx src/pages/quick-start/index.test.tsx：通过。git diff --check upstream/main...HEAD：通过。Scope
Related Issues
Closes #552