fix(web): 拆分 Electron 工作区目录选择与全局工作目录切换#699
Open
Yumiue wants to merge 1 commit into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Review completed. No noteworthy issues found across code quality, performance, security, and documentation accuracy passes. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pickWorkspaceDirectory(),作为 Electron 新建工作区弹窗专用的无副作用目录选择入口pickWorkspaceDirectory(),不再复用会修改全局workdir的selectWorkdir()Changes
RuntimeProviderpickWorkspaceDirectory(): Promise<string | null>window.electronAPI.pickDirectory()nullworkdir,不调用selectWorkdir()Sidebarruntime.pickWorkspaceDirectorytype="button"Tests
createWorkspaceValidation
npm test -- RuntimeProvider.lifecycle.test.tsx Sidebar.test.tsxnpm testnpm run verify:electron-preloadnpm run buildNotes
window.electronAPI.pickDirectory()internal/gateway、internal/runtime、internal/tools、internal/session