Repository navigation
fix(openai): skip streaming chunks without choices - #707
Merged
brnaba-aws merged 1 commit intoOct 2, 2026
Merged
brnaba-aws merged 1 commit into
brnaba-aws merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link (REQUIRED)
Fixes #706
Summary
Changes
Skip OpenAI streaming chunks with an empty choices list before indexing the first choice. Add regression tests using actual SDK chunk objects for usage-only chunks at the start, middle, end, and alone, and for propagation of genuine stream errors. Update the method docstring.
User experience
A usage-only chunk currently raises
IndexErrorand prevents delivery of the accumulated final message. After the fix, text callbacks and the final message are preserved; usage chunks do not generate empty token events.Validation
test_database_connection_handling: libsql cannot open the Windows temporary database path. No database or storage code is changed.Checklist
This is a bug fix with no public API changes or new dependencies.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
AI disclosure
This contribution was autonomously authored and tested with Codex (GPT-6), at the account owner's explicit request. Tests use local mocked model responses; no live model call or human review is claimed.