Fluent constructors for lattice and TPMS families#136
Open
kmarchais wants to merge 4 commits into
Open
Conversation
84e1ec0 to
2c24c43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the long-positional-argument constructors on the lattice and TPMS families with required-positional
__init__+ chainedwith_*setters. Resolves PLR0913 withoutnoqa.Changes
Lattice family
AbstractLattice.__init__(*, center, orientation)only — all geometry params via.with_strut_radius,.with_strut_heights,.with_cell_size,.with_strut_joints,.with_density,.with_base_vertices,.with_strut_vertex_pairsCustomLattice(base_vertices, strut_vertex_pairs, *, center, orientation)— required topology positional, rest chainedstrut_radiuspropertyTPMS family
Tpms(surface_function, *, center, orientation); chainedwith_offset,with_phase_shift,with_cell_size,with_repeat_cell,with_resolution,with_densityCylindricalTpms(radius, surface_function, ...),SphericalTpms(radius, surface_function, ...)— theta / phi auto-snap moved into overridden_init_cell_parametersSweep(curve_points, surface_function, radial_max, ...)plus.with_seed_normal,.with_n_curve_samplesInfill(obj, surface_function, ...)overrideswith_cell_size/with_repeat_cellto derive the other fromobj.boundsGradedInfill(obj, surface_function, ...)exposes.with_gradation(offset_skin, offset_core, transition, smoothness)offsetvsdensity,cell_sizevsrepeat_cellon Infill)Misc
_BBoxconverted to a dataclasspyproject.toml:PLR0913added to[tool.ruff.lint] extend-selectNotes