Repository navigation
fix: refresh images when source files change - #393
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388.
The
from_file()fast path reused an image based only on its path, andImage:render()tracked changes with second-resolutiongetftime. Both can keep stale content after a source changes. Usetransform_cache.source_identity()(canonical path, subsecond mtime, and size) for reuse and render invalidation; refresh dimensions and clear transformed output when the identity changes.The regression rewrites the source without changing its size, changes only the subsecond mtime, and verifies that
getftimeis unchanged while both reload and render refresh the image.Validation: the targeted source-refresh regression passed. The full Busted suite was not run locally because
bustedis unavailable; CI is pending.