Fixes FRU field compare/matching for identical-hardware units (adds hierarchy + fru fallback logic) and Adds manual mode to server_identifier (from old #TODO)#52
Open
JordanKeo45 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds better handling for automatic product type setting (eg, if Q30 unit has same identical hardware as Storinator Q30 and Destroyinator 30, it would erroneously assign Destroyinator instead of Storinator before. now it prefers FRU (set from serialization) if there is a conflict.)
Also adds a manual entry mode for use with server_identifier (original dev had a #TODO note to add it so added it in during this pass as it was useful for testing)
(had these changes in a different branch but ran into merge conflicts so re-added here)