chore: Remove mpmath constraints that lead to improper environment - #1454
Conversation
add option to easy reproduce problem locally using tox
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes restrictive mpmath constraints and adds a Flow diagram for pre-release packaged environment validationflowchart TD
A[pyinstaller-pre tox environment] --> B[uv pip compile with prerelease dependencies]
B --> C[Install compiled requirements]
C --> D[Install PartSeg without dependencies]
D --> E[Build and package executable]
E --> F[Run packaged executable self-test]
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes update problematic-version requirements and add a ChangesPrerelease PyInstaller validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes restrictive dependency constraints and adds a local reproduction environment; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tox.ini" line_range="121-123" />
<code_context>
+allowlist_externals =
+ dist/PartSeg/PartSeg
+commands_pre =
+ uv pip compile --prerelease allow --python-version {py_dot_ver} --upgrade -o {envtmpdir}/requirements-pyinstaller-pre.txt pyproject.toml requirements/pre_test_problematic_version.txt --extra pyinstaller
+ uv pip install -r {envtmpdir}/requirements-pyinstaller-pre.txt
+ uv pip install --no-deps .
</code_context>
<issue_to_address>
**issue (bug_risk):** tox rejects the first `uv pip compile` command as an unallowlisted external command, so `pyinstaller-pre` stops before compiling or installing its requirements.
**Triggers:** When running `tox run -e pyinstaller-pre` under tox 4.
**Suggested fix:** Add `uv` to `allowlist_externals` and ensure the uv executable is installed or otherwise available on PATH.
```suggestion
allowlist_externals =
dist/PartSeg/PartSeg
uv
deps =
uv
commands_pre =
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: tox.ini:123
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|



Add an option to easily reproduce the problem locally using tox.
Closes #1451
Summary by Sourcery
Provide a tox workflow to reproduce and validate the problematic PyInstaller dependency environment.
Enhancements:
Build:
Tests:
Summary by CodeRabbit
Bug Fixes
Tests
Chores