ESS-3841- remove lowerStack() API and collection from SWIM Campaign object - #51
Merged
Merged
Conversation
grzegorz-juras-4ss
changed the title
grzegorz-juras-4ss
added
documentation
grzegorz-juras-4ss
requested review from
bjorn-einar-bjartnes-4ss,
branislav-jenco-4ss and
ivan-nikalaichanka-4ss
May 6, 2026 09:57
ivan-nikalaichanka-4ss
approved these changes
May 6, 2026
ivan-nikalaichanka-4ss
left a comment
ivan-nikalaichanka-4ss
left a comment
Contributor
There was a problem hiding this comment.
I guess removal is fine. As discussed on the planning, it's a breaking change if somebody uses the function - the code will not be executed successfully now. But since we still have the package version 0, we can add a breaking change without a new major version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-3841
Description
Campaigns' Lower Stack APIs are deprecated on 4insight-api. They were not used for months and need to be removed from
campaignspackage.Checklist