fix(security): harden dynamic object maps against prototype pollution - #1283
fix(security): harden dynamic object maps against prototype pollution#1283ghiscoding wants to merge 2 commits into
Conversation
|
Honestly, I feel like this is a bit over the top. The risk of prototype pollution of, for example, the object constructor is pretty low. If the attacker can do that, then it seems likely there are a lot of other attack paths that could be open as well. Ultimately, nothing on the client side is ever to be considered secure, and the only way to enforce security correctly is to check permissions related business logic at the point of entry at the server. But in the end, I have no objection. It doesn't hurt, and if this is recommended, then perhaps it is the response to a particular automated attack vector that is getting traction. |
|
I'll let you decide if you want to merge or not, the reason why this came up was because a researcher team found similar entry in another repo of mine ( |
|
Could you give me more info about the researcher team? |
I forwarded you the email I originally received, it's probably a scanning system that detected it (not the actual researchers but their scanning system) |
replicate Slickgrid-Universal PR 2742 and PR 2743 into SlickGrid by doing a security audit using AI
Summary
Harden SlickGrid's dynamic object maps against prototype pollution risks.
Changes
__proto__,constructor, andtoStringkeys.hasOwnProperty()calls withObject.prototype.hasOwnProperty.call().dist/files as build artifacts; they are not intended for inclusion in the PR.Validation
git diff --checkpassed.LLM
Implemented and reviewed with OpenAI GPT-5.6 Luna.