Skip to content

fix(ccc): rooms ask through AskUserQuestion so the critic can answer; one Ship asker - #101

Merged
8syncdev merged 1 commit into
mainfrom
fix/ask-via-tool
Oct 18, 2026
Merged

8syncdev merged 1 commit into
mainfrom
fix/ask-via-tool

Conversation

@8syncdev

Copy link
Copy Markdown
Contributor

Owner report: "quá 1 phút có agent high level tự trả lời" was not happening.

Found live (ai-game-studio):

  • delegate on, 60 s; su-code/DECISIONS.md empty: the critic never decided anything.
  • rd asked about BiRefNet in prose at the end of a turn (no AskUserQuestion in its transcript) → the PreToolUse delegate hook never fired.
  • lead and ba both asked Ship for PR 20 (duplicate). Ship questions waiting for the owner is by design and stays.

Fix:

  • ASK_RULE in every room's loop tick (and so in the lane rooms' /goal via the loop setup) and in new .claude/loop.md: ask the owner through AskUserQuestion, recommended option first, never in prose before stopping; only the lead asks Ship.
  • Backlog playbook: the approved → Ship step is the lead's only (BA skips).
  • HQ ask panel: Ship questions show "Câu Ship … chỉ anh duyệt. Critic không trả lời thay…"; a prose wait is marked as invisible to the critic.
  • delegate::decide() unchanged: Ship/merge/secret/money/destructive/high-risk stay with the owner.

Tests: cargo verbs::ccc 270 passed (new: ask rule in tick//goal/loop.md, lead-only Ship, /goal ≤ 4,000 chars; the first attempt hit 4,252 and was trimmed); HQ vitest 519/522 (3 known Windows-only), tsc + eslint clean. Live: HQ dev on the real game rooms shows the Ship note on both pending Ship questions. Gates: /sec OK, /rules CONDITIONS met (high-risk stays owner-only), /aup-audit PASS, ccc risk low.

After release: running rooms pick it up with 8sync ccc auto up --clear-ss.

🤖 Generated with Claude Code

… one Ship asker

The delegate hook only sees AskUserQuestion; rd asked in prose and the critic never
got it. Only the lead asks Ship (ba asked it too). HQ marks Ship questions as the
owner's alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@8syncdev
8syncdev merged commit 486094f into main Oct 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant