Repository navigation
fix(ccc): rooms ask through AskUserQuestion so the critic can answer; one Ship asker - #101
Merged
Merged
Conversation
… one Ship asker The delegate hook only sees AskUserQuestion; rd asked in prose and the critic never got it. Only the lead asks Ship (ba asked it too). HQ marks Ship questions as the owner's alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner report: "quá 1 phút có agent high level tự trả lời" was not happening.
Found live (ai-game-studio):
delegateon, 60 s;su-code/DECISIONS.mdempty: the critic never decided anything.Fix:
ASK_RULEin every room's loop tick (and so in the lane rooms'/goalvia the loop setup) and in new.claude/loop.md: ask the owner through AskUserQuestion, recommended option first, never in prose before stopping; only the lead asks Ship.delegate::decide()unchanged: Ship/merge/secret/money/destructive/high-risk stay with the owner.Tests: cargo verbs::ccc 270 passed (new: ask rule in tick//goal/loop.md, lead-only Ship, /goal ≤ 4,000 chars; the first attempt hit 4,252 and was trimmed); HQ vitest 519/522 (3 known Windows-only), tsc + eslint clean. Live: HQ dev on the real game rooms shows the Ship note on both pending Ship questions. Gates: /sec OK, /rules CONDITIONS met (high-risk stays owner-only), /aup-audit PASS, ccc risk low.
After release: running rooms pick it up with
8sync ccc auto up --clear-ss.🤖 Generated with Claude Code