release: v1.12.0 — KMS-TEE deploy helpers + CC-34 keeper signer#211
Conversation
Cuts a release ref that bundles v1.11.0's signing core with everything landed since the v1.11.0 tag, so the CC-24 board recipe can checkout ONE tag that has all of it (the recipe's old `git checkout v1.11.0` predated these): - #206 DK2 armv7 deploy path - #208 write-keyless-node-state.mjs (CC-24 helper ①) - #209 KmsEcdsaSigner (CC-34 keeper ECDSA via KMS-TEE) - #210 dvt.service key-less unit + env (CC-24 helper ②) Bumps package.json 1.11.0 → 1.12.0 and points deploy/kms-tee/README.md at `git checkout v1.12.0`. Tag v1.12.0 is pushed on this merge commit. Claude-Session: https://claude.ai/code/session_01JrdmiUk4A258FmhDSKn9aj
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa7e90d34e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "name": "yetanotheraa-validator", | ||
| "version": "1.11.0", | ||
| "version": "1.12.0", |
There was a problem hiding this comment.
This release bump updates package.json to 1.12.0, but the committed package-lock.json still records the root package as 1.11.0 at both the top-level version field and packages[""].version. In repos that commit the npm lockfile, this leaves the release metadata inconsistent for anyone consuming or auditing the checked-in lockfile; running the existing npm version flow or regenerating the lockfile would update both files together.
Useful? React with 👍 / 👎.
clestons
left a comment
clestons
left a comment
There was a problem hiding this comment.
#211 — APPROVE
Pure release bump: package.json 1.11.0→1.12.0 + deploy/kms-tee/README.md recipe git checkout v1.11.0→v1.12.0. No code. Aggregates the already-reviewed #206 / #208 / #209 / #210 under one tag for the CC-24 A-board recipe.
BUMP-track, PK skipped. Tag v1.12.0 to be pushed on the merge commit post-merge.
…L + old-state removal The A-board has no git, so 'git checkout v1.12.0' can't run on it. Recipe now checks out on the Mac and rsyncs the source (excludes preserve board state; the board still builds DVT's unmodified code via build-bare-node — method ②). Also fixes two correctness gaps found writing the git-less path: - dvt.env.example was missing ETH_RPC_URL, which configuration.ts REQUIRES at boot — added, flagged to preserve the board's existing RPC key. - step 2 now rm's the old v1.7.1 encrypted-keystore node_state before write-keyless (which refuses to overwrite), and step 3 preserves ETH_RPC_URL instead of clobbering dvt.env. Claude-Session: https://claude.ai/code/session_01JrdmiUk4A258FmhDSKn9aj
clestons
left a comment
clestons
left a comment
There was a problem hiding this comment.
#211 — APPROVE (re-review)
My prior approve was auto-dismissed by new commit 238d94c. It only touches README.md recipe + dvt.env.example (docs/config, no code):
- git-less board workaround: checkout v1.12.0 on the Mac +
rsync -a --deletewith excludes preserving board state (.git/node_modules/node_state.json/dvt.env/dvt.log) — builds DVT's unmodified source ✓ - swap old v1.7.1 encrypted-keystore
node_state.jsonfor the key-less one ✓ ⚠️ correctly warns to PRESERVE the board's existingETH_RPC_URL(don't clobber the working key) + adds it to the template as REQUIRED ✓
Still a pure bump/docs PR (package.json 1.12.0 + recipe). No code. Re-approving on the current head.
2 participants
Cuts v1.12.0 so the CC-24 A-board recipe can
git checkoutone tag that has everything KMS node-setup needs. KMS correctly flagged that the recipe'sgit checkout v1.11.0predated the helpers — all of these landed on master after the v1.11.0 tag:write-keyless-node-state.mjs(CC-24 helper ①)KmsEcdsaSigner(CC-34 keeper ECDSA via KMS-TEE)dvt.servicekey-less unit + env (CC-24 helper ②)Changes:
package.json1.11.0 → 1.12.0;deploy/kms-tee/README.mdrecipe →git checkout v1.12.0. After merge I push tagv1.12.0on the merge commit and @ KMS on CC-24.(Immediate unblock already given to KMS: commit
cbc25c3= current master has all three, identical content to what v1.12.0 will tag.)https://claude.ai/code/session_01JrdmiUk4A258FmhDSKn9aj