fix(tests): skip the actuation splice tests when ace-skills is absent - #34
Merged
contactacefleetdev merged 1 commit intoAug 28, 2026
Merged
Conversation
Both tests assert that actuation *changed the outbound bytes*, which only happens when `ace-skills` is installed — it supplies the splice mechanics `ShadowRunner.actuate` imports lazily. That package is deliberately not a dependency of the sidecar, so CI's `pip install -e .[test]` never has it and `actuate` refuses by design, returning the original bytes. Guard the two byte-changing tests with a skipif. Actuation's refusal paths and `test_the_sidecar_still_works_with_no_lever_package_installed` still run unconditionally, so the no-package behaviour stays covered.
contactacefleetdev
deleted the
fix/ci-actuation-tests-skip-without-ace-skills
branch
August 28, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both tests assert that actuation changed the outbound bytes, which only happens when
ace-skillsis installed — it supplies the splice mechanicsShadowRunner.actuateimports lazily. That package is deliberately not a dependency of the sidecar, so CI'spip install -e .[test]never has it andactuaterefuses by design, returning the original bytes.Guard the two byte-changing tests with a skipif. Actuation's refusal paths and
test_the_sidecar_still_works_with_no_lever_package_installedstill run unconditionally, so the no-package behaviour stays covered.Description
Summarize the changes made in this Pull Request and the problem being solved.
Type of Change
Verification
Describe the tests and checks performed to verify changes:
pytestpasses cleanly.python -m buildandtwine check dist/*pass.scripts/e2e_test.pypasses.Checklist
CHANGELOG.mdwith my changes.