Fix proper clipping compatibility?#38
Merged
Merged
Conversation
I love race conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primitives reinitialize their physics with no regard to proper clips.
On the Server realm, physical clips are wiped after primitives reinitialize.
On the Client realm, physical clips are attempted every 100ms until ent.SpawnEffect happens, which is almost always after the primitive re initializes.
This creates a discrepancy on the client and the server.
To fix this race condition, we should preserve clips after a primitive rebuilds.
We currently have no control over proper clipping, so this is a minimally invasive fix which can accommodate.