Skip to content

drop shutdown timer because it does not work - #146

Merged
jschoedl merged 2 commits into
mainfrom
drop-shutdown-timer
Jul 19, 2026
Merged

drop shutdown timer because it does not work#146
jschoedl merged 2 commits into
mainfrom
drop-shutdown-timer

Conversation

@jschoedl

@jschoedl jschoedl commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

drop azure shutdown timer because it does not work, just use manual instance shutdown instead

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Infrastructure / CI
  • Documentation

API changes

  • This PR does not affect the API
  • This PR changes the API → api/openapi.yaml updated and api/scripts/gen-all.sh re-run

Definition of Done

  • CI passes
  • Pre-commit hooks pass locally
  • Relevant tests added or updated

Summary by CodeRabbit

  • New Features

    • Starting an environment no longer requires configuring an automatic shutdown duration.
    • The start workflow now provides the environment URL and instructs users to stop the environment when finished.
  • Bug Fixes

    • Removed outdated auto-shutdown behavior and messaging from the environment startup process.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jschoedl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 836d3d6e-7e57-4b52-a98a-b25ba2af2e20

📥 Commits

Reviewing files that changed from the base of the PR and between 59e7682 and a438535.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

The VM start workflow removes the configurable auto-shutdown duration, stops calculating and passing shutdown variables, removes the Azure auto-shutdown command, and directs operators to use Stop environment to stop billing.

Changes

VM start workflow

Layer / File(s) Summary
Simplify workflow inputs and token setup
.github/workflows/vm-start.yml
The manual trigger no longer defines minutes; OIDC token preparation and Azure CLI invocation now use only the federated token.
Remove shutdown execution and update summary
.github/workflows/vm-start.yml
The Azure script no longer configures VM auto-shutdown and now reports the environment URL with instructions to run Stop environment to stop billing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: removing the broken shutdown timer in favor of manual shutdown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-shutdown-timer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jschoedl
jschoedl merged commit dc4ef1c into main Jul 19, 2026
1 check was pending
@jschoedl
jschoedl deleted the drop-shutdown-timer branch July 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant