Skip to content

Feat/add streamhelper - #3

Open
senslab-MarkHawkins wants to merge 3 commits into
AFRL-ARES:Developfrom
senslab-MarkHawkins:feat/add_streamhelper
Open

Feat/add streamhelper#3
senslab-MarkHawkins wants to merge 3 commits into
AFRL-ARES:Developfrom
senslab-MarkHawkins:feat/add_streamhelper

Conversation

@senslab-MarkHawkins

Copy link
Copy Markdown

Added driver to handle sensors streaming serial data on a dedicated port. Steam configuration (headers) can be configured in the UI and appropriately update state and UI elements. A helper library was created to calculate stats on a data stream which can be reused in other projects.

@nkleiner

Copy link
Copy Markdown
Member

It looks like you committed a copy of the packaged driver itself with your changes. We avoid doing this to keep the repo from getting bloated with packaged versions of drivers, instead we rely on the pipelines that care about the drivers to package them at runtime.

@nkleiner

Copy link
Copy Markdown
Member

The existence of the "StreamHelper" library here is a bit of an oddity. The device driver repo should really only contain the drivers themselves. I think there's two options for how to approach handling the stream helper library:

  1. If we think this is a pretty universally helpful set of tools, then perhaps it belongs in either it's own dedicated tool library or maybe as part of one of the existing toolkits (such as the serial toolkit perhaps?)
  2. If this is really only useful to the device you've created here, then it should probably just live there as a set of static calls for that device to use

I'm open to either as a solution, but definitely don't think it should linger as its own project in this repo

@senslab-MarkHawkins

senslab-MarkHawkins commented Aug 17, 2026 via email

Copy link
Copy Markdown
Author

@nkleiner

Copy link
Copy Markdown
Member

I gave it some thought, and I think this has a place in the Ares.Toolkit.Device library specifically. My suggestion would be taking the stream helper class and adding it to a new "Ares.Toolkit.Device.Telemetry" namespace. This means we can continue to re-use this logic across devices while also giving a clear path forward for creating additional telemetry focused helper classes which seems likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants