Update 2dfsdp logical rule#3805
Merged
copybara-service[bot] merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
The Pull Request correctly updates the logical axis rules for the DeepSeek3 2D FSDP configuration. It enables more efficient memory distribution for the large vocabulary embedding layer and aligns the MoE logical axes with the core model implementation.
🔍 General Feedback
- Optimization: Enabling 2D sharding (
fsdpandfsdp_transpose) forembed_vocabis a solid improvement for handling the large embedding weights in a 2D mesh configuration. - Consistency: Adding the
mlp_moerule ensures consistent sharding behavior across MoE components, matching the expected axis names in the model code. - Cleanup: Removing unused axis names (
embed_no_exp,mlp_only_tensor, etc.) reduces clutter and potential confusion in the configuration file.
suexu1025
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update 2dfsdp logical rule supporting FSDP+FSDP_T
Tests
Train compile test: https://paste.googleplex.com/4570213325602816
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.