Fixed e2e test for Qwen3.5-35b-a3b - #5094
Open
AusarYao28 wants to merge 1 commit into
Open
Conversation
AusarYao28
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
September 1, 2026 23:00
There was a problem hiding this comment.
Code Review
This pull request updates the Qwen3 model implementation to cast recurrent states (final_h and next_recurrent_state) to their appropriate target data types (compute_dtype and cfg.dtype). It also modifies an end-to-end test script for Qwen3.5-35b-a3b to disable sparse_matmul during the forward pass logit check. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AusarYao28
force-pushed
the
yaoyuchen-qwen-fix
branch
from
September 2, 2026 06:26
f5b78a3 to
d9520c4
Compare
AusarYao28
force-pushed
the
yaoyuchen-qwen-fix
branch
from
September 2, 2026 06:41
d9520c4 to
0327fbd
Compare
Collaborator
Author
Rohan-Bierneni
approved these changes
Sep 2, 2026
shuningjin
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the failing end-to-end test for Qwen3.5-35b-a3b. Caused by sparse_matmul option issue and mismatch dtype in qwen 3 implementation
FIXES: b/553630181
Tests
xpk workload create --cluster=v5p-128-bodaborg-europe-west4-b --zone=europe-west4-b --project=cloud-tpu-multipod-dev --tpu-type=v5p-128 --num-slices=1 --priority=medium --workload=yaoyuchen-qwen35-35b-e2e --command="bash tests/end_to_end/tpu/qwen/moe/qwen3.5-35b-a3b/2_test_qwen3.5_35b_a3b.sh" --docker-image=gcr.io/cloud-tpu-multipod-dev/yaoyuchen_google_com-runner:latest
Result: https://pantheon.corp.google.com/kubernetes/workload/overview?project=cloud-tpu-multipod-dev&pageState=(%22workload_list_table%22:(%22f%22:%22%255B%257B_22k_22_3A_22Is%2520system%2520object_22_2C_22t_22_3A11_2C_22v_22_3A_22_5C_22False_~*false_5C_22_22_2C_22i_22_3A_22is_system_22%257D_2C%257B_22k_22_3A_22_22_2C_22t_22_3A10_2C_22v_22_3A_22_5C_22yaoyuchen_5C_22_22%257D%255D%22))
Checklist
gemini-reviewlabel.