Conversation
Signed-off-by: LI MOU <lxglbk@gmail.com>
limou102
requested review from
JohnQinAMD,
jiejingzhangamd and
xiaobochen-amd
as code owners
September 16, 2026 09:12
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Formatting-only changes were reviewed with no unresolved issues.
Pull request overview
Restores repository-pinned Ruff formatting across three projection files without changing behavior.
Changes:
- Reformats projection test assertions and comprehensions.
- Reformats validation error messages.
- Resolves the reported CI lint failure.
File summaries
| File | Description |
|---|---|
tests/unit/projection/test_tuning_disaggregated_pools.py |
Ruff formatting updates |
tests/unit/projection/test_prefill_curve_extrapolation.py |
Ruff formatting update |
infera/projection/agents/tuning_agent/inference_tuning.py |
Ruff formatting updates |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: LI MOU <lxglbk@gmail.com>
limou102
changed the title
Signed-off-by: LI MOU <lxglbk@gmail.com>
Signed-off-by: LI MOU <lxglbk@gmail.com>
Signed-off-by: LI MOU <lxglbk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The latest full CI run on
mainfirst fails inlintbecause Ruff reformats three projection files added by recent merges. After that formatting fix, the first PR run reaches GPU testing ande2e-mixed (sglang)lands oncrsuse2-m2m-054, whose containerd storage is full.This PR applies the exact Ruff output and treats
no space left on deviceduring a dispatched tier as a node failure: the harness excludes the named node and retries elsewhere within the existing five-submission limit.Type of change
Changes
Checklist:
Validation
SKIP=gofmt pre-commit run --all-files --show-diff-on-failurepytest -q tests/unit/projection(290 passed, 80 skipped)pytest -q tests/unit/e2e_harness/test_slurm_retry_limit.py(12 passed)Main reproduction: https://github.com/AMD-AGI/Infera/actions/runs/35077892039
First PR run: https://github.com/AMD-AGI/Infera/actions/runs/35078093915