Conversation
kTorp
marked this pull request as ready for review
September 7, 2026 08:10
kTorp
force-pushed
the
feature/omni-minimax-h3
branch
from
September 8, 2026 07:19
784ee21 to
b7bce1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds MiniMax-H3 configurations and updates the runner to handle new flags. Additionally cleans up some unused configs and code.
Background
MiniMax-H3 is a new and popular model that is updated almost daily in vllm-omni and is of interest to track. The configs are based on the available examples in recipes/MiniMaxAI/MiniMax-H3.md
Changes to the online runner due to new MiniMax-H3 configs:
--aspect_ratio,--task_typeand--vae_parallel_modeflags used by MiniMax-H3 recipes_parse_json_objectstring since--diffusion_attention_configis no longer the only json object from configsOther misc changes to online runner:
--attention_backendnow targets the--diffusion-attention-backendflag instead of the ENV variablemax_sequence_lengthsince it defaults to 512 in Flux.2 (and no need to specify with removal of Flux.1 config)Cleanups:
Tasks
Tests