pytorch-xdit:v26.9 MAD integration - #59
Conversation
Fixed json formatting Fixed models.json Fixed script relative path in models.json
lauri9
left a comment
lauri9
left a comment
There was a problem hiding this comment.
The new workload definitions look okay!
I'm not following why the change to the scripts and dockerfile paths, but if this has been tested already should be fine as well.
| "name": "pyt_xdit_flux", | ||
| "dockerfile": "docker/pyt_xdit", | ||
| "scripts": "scripts/pyt_xdit/run.sh", | ||
| "dockerfile": "../../docker/pyt_xdit", |
There was a problem hiding this comment.
I see that the paths for dockerfile and scripts have changed throughout. Is the relative path for dockerfile relative to the location of this file, integrations/MAD/MAD/? If so, would ../.. not point one level too high, at ./integrations/ instead of the root of the repository?
There was a problem hiding this comment.
Some confusions exists with our structure, true. The point is that the new relative paths align with the new MAD repository directory structure. They have been tested during the QA process. integrations/MAD/MAD contents is nowadays purely copy to a MAD repository. I have now updated integrations/MAD/README.md accordingly
lauri9
left a comment
lauri9
left a comment
There was a problem hiding this comment.
Thank you, this is now clear
2 participants
Updates ROCm/MAD capability to cover pytorch-xdit:v26.9 release
Goals
Enable pytorch-xdit:v26.9 runs through Model Automation and Dashboarding (ROCm/MAD)
Tasks
Complete
models.jsonmodels.jsonand enablerun.shand Dockerfile access with relative pathsto cover all goals.
Tests
Tested internally during QA process.