feat: Display clusterName on footer and heading - #190
Open
mariodruiz wants to merge 4 commits into
Open
Conversation
PlatformInfoHandler had no coverage, which is why the XSRF 403 that made every React heading fall back to the hardcoded platform name reached production. Assert the endpoint reports the cluster-suffixed name and that the XSRF override stays in place. Restores the real tornado.web when a sibling test has replaced it with a bare stub, which also clears 12 pre-existing collection errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #150, adding the
clusterNameon the heading and the footer. Before it was only displayed in the login page and tab name.Checklist