Skip to content

Fix flattened observable IDs in PEtab v2 test - #3394

Merged
dweindl merged 1 commit into
AMICI-dev:mainfrom
dweindl:fix_petab_flatten_test_ids
Oct 15, 2026
Merged

dweindl merged 1 commit into
AMICI-dev:mainfrom
dweindl:fix_petab_flatten_test_ids

Conversation

@dweindl

@dweindl dweindl commented Oct 15, 2026

Copy link
Copy Markdown
Member

Fix test_flatten_timepoint_specific_output_overrides for the current libpetab-python main.

Since PEtab-dev/libpetab-python#545, petab_math_str prints double-precision floats such that they round-trip, e.g., 1 instead of 1.00000000000000. The flattened observable IDs are derived from the override values, so they are now obs1__obsParOverride1_1__noiseParOverride1 instead of obs1__obsParOverride1_1_00000000000000__noiseParOverride1. This test fails on main since then.

🤖 Generated with Claude Code

Since PEtab-dev/libpetab-python#545, `petab_math_str` prints floats
such that they round-trip (`1` instead of `1.00000000000000`), which
changes the flattened observable IDs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.95%. Comparing base (3f3c9b0) to head (ac0af58).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3394      +/-   ##
==========================================
- Coverage   79.98%   79.95%   -0.03%     
==========================================
  Files         320      320              
  Lines       22674    22674              
  Branches     1531     1532       +1     
==========================================
- Hits        18135    18129       -6     
- Misses       4531     4537       +6     
  Partials        8        8              
Flag Coverage Δ
cpp 74.06% <ø> (-0.03%) ⬇️
cpp_python 35.08% <ø> (ø)
petab 48.46% <100.00%> (ø)
petab_sciml 16.87% <ø> (ø)
petab_sciml_benchmarks 15.45% <ø> (ø)
python 72.21% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tests/petab_/test_petab_v2.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
dweindl marked this pull request as ready for review October 15, 2026 10:26
@dweindl
dweindl requested a review from a team as a code owner October 15, 2026 10:26
@dweindl dweindl self-assigned this Oct 15, 2026
@dweindl

dweindl commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

I'll merge that to unblock main. Can be replaced by #3398 later, which produces nicer IDs.

@dweindl
dweindl merged commit f03ef36 into AMICI-dev:main Oct 15, 2026
29 checks passed
@dweindl
dweindl deleted the fix_petab_flatten_test_ids branch October 15, 2026 11:39
@dweindl dweindl added the PEtab PEtab-import related label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PEtab PEtab-import related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants