Repository navigation
Fix flattened observable IDs in PEtab v2 test - #3394
Merged
Merged
Conversation
Since PEtab-dev/libpetab-python#545, `petab_math_str` prints floats such that they round-trip (`1` instead of `1.00000000000000`), which changes the flattened observable IDs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3394 +/- ##
==========================================
- Coverage 79.98% 79.95% -0.03%
==========================================
Files 320 320
Lines 22674 22674
Branches 1531 1532 +1
==========================================
- Hits 18135 18129 -6
- Misses 4531 4537 +6
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Oct 15, 2026
Member
Author
|
I'll merge that to unblock main. Can be replaced by #3398 later, which produces nicer IDs. |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
test_flatten_timepoint_specific_output_overridesfor the current libpetab-pythonmain.Since PEtab-dev/libpetab-python#545,
petab_math_strprints double-precision floats such that they round-trip, e.g.,1instead of1.00000000000000. The flattened observable IDs are derived from the override values, so they are nowobs1__obsParOverride1_1__noiseParOverride1instead ofobs1__obsParOverride1_1_00000000000000__noiseParOverride1. This test fails onmainsince then.🤖 Generated with Claude Code