Conversation
this is consistent with our naming convention that test_* tests use a grid of cells.
Member
Author
|
addresses #2072 I need to fix the behavior at the edge of tables. I also need to deal with the species normalization -- we might just want to drop to linear for the species. |
Member
Author
|
I also need to fix the T derivative of the interpolation. Because we are nonlinear, we need to do things in the same order as the original interpolation and for the final interpolation (now rho), we need to limit on the function values, not derivatives, from the second pass. So this would require a new interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue where even if the data were all positive, we could get negative values in the interpolation due to undershoots in the existing cubic interpolation.
There is one downside though -- because the limiting is nonlinear, it no longer guarantees that sum{X_i} = 1.