Skip to content

[WIP] Use monotonic cubic Hermite interpolation for the NSE table - #2092

Open
zingale wants to merge 11 commits into
AMReX-Astro:developmentfrom
zingale:use_monotonic_cubic_interp
Open

zingale wants to merge 11 commits into
AMReX-Astro:developmentfrom
zingale:use_monotonic_cubic_interp

Conversation

@zingale

@zingale zingale commented Sep 12, 2026

Copy link
Copy Markdown
Member

This addresses an issue where even if the data were all positive, we could get negative values in the interpolation due to undershoots in the existing cubic interpolation.

There is one downside though -- because the limiting is nonlinear, it no longer guarantees that sum{X_i} = 1.

@zingale

zingale commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

addresses #2072

I need to fix the behavior at the edge of tables.

I also need to deal with the species normalization -- we might just want to drop to linear for the species.

@zingale

zingale commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

I also need to fix the T derivative of the interpolation. Because we are nonlinear, we need to do things in the same order as the original interpolation and for the final interpolation (now rho), we need to limit on the function values, not derivatives, from the second pass. So this would require a new interface.

@zingale zingale added the nse label Sep 14, 2026
@zingale
zingale changed the base branch from main to development September 14, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant