fix issues 111 112 113 114 115 116 - #123
Merged
Merged
Conversation
- AMReX-Fluids#111 construct_hydro_source (EB): decide the regular-box fallback on grow(bx,4), since the non-EB kernels read q out to distance 4 and flatten() disagrees with flatten_eb() within 3 cells of a cut cell. Without this the fluxes on a shared face differ between the two sides and the answer depends on the box layout. - AMReX-Fluids#112 main.cpp moving-EB loop: stop calling finalize_EB2() every step, which destroyed the EB2 index space that the live level factories still point into. Build the new space only once time has advanced and erase the previous one after the step, when the forced regrid has rebuilt every level. Abort up front unless amr.regrid_int = 1 and amr.force_regrid_level_zero = 1, which the scheme requires. - AMReX-Fluids#113 clean_state now takes an explicit ghost count instead of using S.nGrow(): with CAMR.state_nghost > 0 it ran computeTemp over ghost cells of the state data that nothing ever fills. Also corrects the stale enforce_min_density comment, which described an S_old argument and a return value the function does not have and claimed it touches ghost zones. - AMReX-Fluids#114 setPlotVariables no longer strips the species from an explicit amr.plot_vars list when CAMR.plot_rhoy was never set. - AMReX-Fluids#115 read_tagging_params: the 24 tagging.* keys were parsed into a struct nothing reads, silently ignoring user thresholds. Refuse them with a message pointing at amr.refinement_indicators. - AMReX-Fluids#116 delete Source/CAMR_initial_redist.cpp, an orphaned stub that is in no build file, declared in no header, called from nowhere, and would not compile. Built and ran Exec/Sod (2D, non-EB), Exec/SodPlusSphere (2D, EB) and Exec/MovingEBCases/MovingPlane_Shock (3D, moving EB). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #111, fixes #112, fixes #113, fixes #114, fixes #115, fixes #116
CAMR::construct_hydro_source (EB): regular-box fallback is decided on grow(bx,2|3) but the non-EB kernels read to distance 4 and flatten() differs from flatten_eb() there, so face fluxes at box boundaries near the body depend on the box layout #111 construct_hydro_source (EB): decide the regular-box fallback on grow(bx,4), since the non-EB kernels read q out to distance 4 and flatten() disagrees with flatten_eb() within 3 cells of a cut cell. Without this the fluxes on a shared face differ between the two sides and the answer depends on the box layout.
main.cpp CAMR_USE_MOVING_EB loop: finalize_EB2() every step destroys the EB2 index space live level factories still point to; the next regrid reads freed memory, and geometry only "moves" via regrid_int=1 #112 main.cpp moving-EB loop: stop calling finalize_EB2() every step, which destroyed the EB2 index space that the live level factories still point into. Build the new space only once time has advanced and erase the previous one after the step, when the forced regrid has rebuilt every level. Abort up front unless amr.regrid_int = 1 and amr.force_regrid_level_zero = 1, which the scheme requires.
CAMR::clean_state runs computeTemp over S.nGrow() ghost cells that were never filled when state_nghost > 0 #113 clean_state now takes an explicit ghost count instead of using S.nGrow(): with CAMR.state_nghost > 0 it ran computeTemp over ghost cells of the state data that nothing ever fills. Also corrects the stale enforce_min_density comment, which described an S_old argument and a return value the function does not have and claimed it touches ghost zones.
CAMR::setPlotVariables silently deletes species the user listed in amr.plot_vars #114 setPlotVariables no longer strips the species from an explicit amr.plot_vars list when CAMR.plot_rhoy was never set.
CAMR::read_tagging_params reads 24
tagging.*inputs that nothing ever uses; user thresholds are silently ignored #115 read_tagging_params: the 24 tagging.* keys were parsed into a struct nothing reads, silently ignoring user thresholds. Refuse them with a message pointing at amr.refinement_indicators.Source/CAMR_initial_redist.cpp (added by PR #104) is an orphaned, non-compilable stub that is not in the build #116 delete Source/CAMR_initial_redist.cpp, an orphaned stub that is in no build file, declared in no header, called from nowhere, and would not compile.
Built and ran Exec/Sod (2D, non-EB), Exec/SodPlusSphere (2D, EB) and Exec/MovingEBCases/MovingPlane_Shock (3D, moving EB).