Skip to content

fix issues 111 112 113 114 115 116 - #123

Merged
asalmgren merged 1 commit into
AMReX-Fluids:developmentfrom
asalmgren:fix-issues-111-116
Sep 14, 2026
Merged

asalmgren merged 1 commit into
AMReX-Fluids:developmentfrom
asalmgren:fix-issues-111-116

Conversation

@asalmgren

Copy link
Copy Markdown
Contributor

fixes #111, fixes #112, fixes #113, fixes #114, fixes #115, fixes #116

Built and ran Exec/Sod (2D, non-EB), Exec/SodPlusSphere (2D, EB) and Exec/MovingEBCases/MovingPlane_Shock (3D, moving EB).

- AMReX-Fluids#111 construct_hydro_source (EB): decide the regular-box fallback on
  grow(bx,4), since the non-EB kernels read q out to distance 4 and
  flatten() disagrees with flatten_eb() within 3 cells of a cut cell.
  Without this the fluxes on a shared face differ between the two sides
  and the answer depends on the box layout.

- AMReX-Fluids#112 main.cpp moving-EB loop: stop calling finalize_EB2() every step,
  which destroyed the EB2 index space that the live level factories still
  point into.  Build the new space only once time has advanced and erase
  the previous one after the step, when the forced regrid has rebuilt
  every level.  Abort up front unless amr.regrid_int = 1 and
  amr.force_regrid_level_zero = 1, which the scheme requires.

- AMReX-Fluids#113 clean_state now takes an explicit ghost count instead of using
  S.nGrow(): with CAMR.state_nghost > 0 it ran computeTemp over ghost
  cells of the state data that nothing ever fills.  Also corrects the
  stale enforce_min_density comment, which described an S_old argument
  and a return value the function does not have and claimed it touches
  ghost zones.

- AMReX-Fluids#114 setPlotVariables no longer strips the species from an explicit
  amr.plot_vars list when CAMR.plot_rhoy was never set.

- AMReX-Fluids#115 read_tagging_params: the 24 tagging.* keys were parsed into a
  struct nothing reads, silently ignoring user thresholds.  Refuse them
  with a message pointing at amr.refinement_indicators.

- AMReX-Fluids#116 delete Source/CAMR_initial_redist.cpp, an orphaned stub that is
  in no build file, declared in no header, called from nowhere, and
  would not compile.

Built and ran Exec/Sod (2D, non-EB), Exec/SodPlusSphere (2D, EB) and
Exec/MovingEBCases/MovingPlane_Shock (3D, moving EB).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@asalmgren
asalmgren merged commit ca188fb into AMReX-Fluids:development Sep 14, 2026
2 checks passed
@asalmgren
asalmgren deleted the fix-issues-111-116 branch September 14, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment