Cleanup input module#163
Draft
AMythicDev wants to merge 16 commits into
Draft
Conversation
AMythicDev
force-pushed
the
cleanup-input-module
branch
from
ec791cd to
ba59118
Compare
* Massively faster incremental search by highlighting only the visible lines * Full buffer is only highlighted once the search query is confirmed * All searches (including incremental previews) now wrap around to the opposite direction when no match found
* Remove our custom rudimentary implementation of a readline prompt with rustyline. * [BREAKING] SearchOpts dropped various fields like `ev`, `string` etc. * [BREAKING] The incremental search conditiob callback function now takes an additional parameter of type `&str` that will contain the query present in the prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputClassifierandDefaultInputClassifier.HashedEventRegisterandgenerate_default_bindings()are now private.Pager::map_*()andPager::clear_*()functions to add/remove mappings for keys, mice, resize, and a catch-all wild event.To be included in the next major release.