Repository navigation
fix(evoprompt): avoid overflow when counting prompt combinations - #288
Open
liuzhengyang699 wants to merge 1 commit into
Open
liuzhengyang699 wants to merge 1 commit into
liuzhengyang699 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvoPrompt counts the prompt combinations with
np.prod, so the search-space size can overflow a fixed-width integer even when only a few candidates are requested. With 16 nodes and 16 prompts per node the count wraps to zero and no candidates are produced. With 19 nodes and 10 prompts per node it wraps negative, causing the sampler to enter the full Cartesian-product branch.Use
math.prodto keep the count exact while preserving the existing sampling limits. The regression tests cover both overflow cases with default and explicit sample sizes, as well as small and empty populations. The large-space tests reject full enumeration immediately.Validation:
pytest tests/src/optimizers/test_evoprompt_combinations.py tests/src/optimizers/test_evoprompt_state_isolation.py tests/src/optimizers/test_optimizer_package_imports.py -q— 10 passed. Ruff passed for the new test file;git diff --checkpassed.