Repository navigation
fix(map-elites): isolate seeded evolutionary search randomness - #289
Open
liuzhengyang699 wants to merge 1 commit into
Open
liuzhengyang699 wants to merge 1 commit into
liuzhengyang699 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapElitesOptimizer(random_seed=...)reseeds Python's global generator, and every exploration, parent-selection and mutation draw uses that same generator. Constructing another optimizer or consuming randomness in the evaluator therefore changes the candidate sequence despite the fixed seed; constructing the optimizer also changes randomness for unrelated callers.Keep a
random.Random(random_seed)instance on the optimizer and use it for all search draws. The search remains stochastic when no seed is supplied.Validation:
python -m pytest tests/src/optimizers/test_map_elites_optimizer.py tests/src/optimizers/test_optimizer_package_imports.py -q— 4 passed. Both new regressions fail on upstream: global RNG state changes, and identical seeded optimizers produce different candidate histories when the evaluator consumes random numbers. Focused Ruff correctness checks (E4,E7,E9,F) andgit diff --checkpassed. Full Ruff still reports pre-existing typing/import-style findings in these files. No model calls.