chore: comment truth sweep#81
Conversation
- Drop stale (OTel v1.40) banner/doc claims; pin is v1.41.0 (schema's own v1_41 'Current compatibility pin') - Delete dead references: NamespaceRoutingTable.cs, Mandate §Commit-4, specs/telemetry-intelligence.md, *.g.cs static registries (nothing in the workspace consumes or contains these) - Drop PR-provenance and extraction-era narration (qyl PR #255, 'as promised') - Delete HANDOFF.md: dated 2026-06-13 pre-release handoff, fully superseded (v0.2.1/v0.2.2 released; its open items no longer exist in the tree) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (25)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Comment/doc-only sweep across the TypeSpec source tree to keep the qyl API schema’s narrative and banner text accurate (without changing schema semantics), plus removal of a stale handoff document.
Changes:
- Removed/neutralized stale OpenTelemetry semantic convention version claims (e.g., “OTel v1.40”) in model headers and a few
@doc(...)strings. - Deleted dead/obsolete references to non-existent files and prior PR provenance narration in comments.
- Deleted
HANDOFF.mdas an outdated, pre-release operational handoff note.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| otel/enums.tsp | Removes a hardcoded semconv version claim from the banner comment. |
| models/test.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/system.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/session.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/rpc.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/otel-config.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/messaging.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/log.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/identity.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/http.tsp | Drops “Complete OTel v1.40” wording and removes versioned @doc text. |
| models/genai.tsp | Drops “Complete OTel v1.40”/provenance phrasing and removes versioned @doc text. |
| models/error.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/deployment.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/db.tsp | Drops “Complete OTel v1.40” wording and removes versioned @doc text. |
| models/agent/workflow-execution.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/agent/workflow-checkpoint.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/agent/tool-call.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| models/agent/agent-run.tsp | Removes “(OTel v1.40)” from the header banner comment. |
| main.tsp | Removes PR-provenance wording and updates “Extracted …” phrasing to local/domain wording. |
| intelligence/seed/strategies.tsp | Removes dead references to external specs/static registries in comments. |
| intelligence/seed/rules.tsp | Removes dead references to external specs/static registries in comments. |
| intelligence/seed/patterns.tsp | Removes dead references to external specs/static registries while keeping seed provenance. |
| intelligence/main.tsp | Removes a “source of truth” comment pointing at a non-existent spec file. |
| emit-config.tsp | Removes dead references (“NamespaceRoutingTable.cs”, “Mandate §Commit-4”) from comments. |
| HANDOFF.md | Deletes an outdated, no-longer-relevant handoff document. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment/doc-only sweep; no schema semantics changed.
Deleted (verified against the tree before each cut):
(OTel v1.40)version claims in 20+ model banner comments and three@docstrings — the repo's pin is v1.41.0 (common/types.tspdeclaresv1_41: Current compatibility pin; generated keys are v1.41.0).NamespaceRoutingTable.csand "Mandate §Commit-4" inemit-config.tsp,specs/telemetry-intelligence.mdand*.g.csstatic-registry claims inintelligence/— none of these files exist anywhere in the workspace and nothing consumes them.HANDOFF.md— dated 2026-06-13 pre-release handoff; releases v0.2.1/v0.2.2 have since shipped and its open items (e.g. thefail-on-diagnosticsdead knob) no longer exist in the tree.Kept: seed pattern/rule/strategy comment blocks in
intelligence/seed/(they ARE the seed data), versioned-enum history docs, the otelconventions-lint registry '1.40' provenance note (a maintenance instruction, not a claim about the pin).Verification (complete-and-verified):
npm run lint(build:emitters + tsp compile --warn-as-error): Compilation completed successfullynpm run lint:public: Compilation completed successfully🤖 Generated with Claude Code