Skip to content

chore: comment truth sweep#81

Merged
ANcpLua merged 1 commit into
mainfrom
chore/comment-truth-sweep
Jul 3, 2026
Merged

chore: comment truth sweep#81
ANcpLua merged 1 commit into
mainfrom
chore/comment-truth-sweep

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Comment/doc-only sweep; no schema semantics changed.

Deleted (verified against the tree before each cut):

  • Stale (OTel v1.40) version claims in 20+ model banner comments and three @doc strings — the repo's pin is v1.41.0 (common/types.tsp declares v1_41: Current compatibility pin; generated keys are v1.41.0).
  • Dead references: NamespaceRoutingTable.cs and "Mandate §Commit-4" in emit-config.tsp, specs/telemetry-intelligence.md and *.g.cs static-registry claims in intelligence/ — none of these files exist anywhere in the workspace and nothing consumes them.
  • PR-provenance narration: "Extracted from qyl PR #255", "(18+ enums as promised)", "Extracted" labels.
  • HANDOFF.md — dated 2026-06-13 pre-release handoff; releases v0.2.1/v0.2.2 have since shipped and its open items (e.g. the fail-on-diagnostics dead knob) no longer exist in the tree.

Kept: seed pattern/rule/strategy comment blocks in intelligence/seed/ (they ARE the seed data), versioned-enum history docs, the otelconventions-lint registry '1.40' provenance note (a maintenance instruction, not a claim about the pin).

Verification (complete-and-verified):

  • npm run lint (build:emitters + tsp compile --warn-as-error): Compilation completed successfully
  • npm run lint:public: Compilation completed successfully
  • Diff audited: every changed line is a comment, a doc string, or the HANDOFF.md deletion

🤖 Generated with Claude Code

- Drop stale (OTel v1.40) banner/doc claims; pin is v1.41.0 (schema's own
  v1_41 'Current compatibility pin')
- Delete dead references: NamespaceRoutingTable.cs, Mandate §Commit-4,
  specs/telemetry-intelligence.md, *.g.cs static registries (nothing in the
  workspace consumes or contains these)
- Drop PR-provenance and extraction-era narration (qyl PR #255, 'as promised')
- Delete HANDOFF.md: dated 2026-06-13 pre-release handoff, fully superseded
  (v0.2.1/v0.2.2 released; its open items no longer exist in the tree)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 3, 2026 03:45
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (25)
  • HANDOFF.md is excluded by none and included by none
  • emit-config.tsp is excluded by none and included by none
  • intelligence/main.tsp is excluded by none and included by none
  • intelligence/seed/patterns.tsp is excluded by none and included by none
  • intelligence/seed/rules.tsp is excluded by none and included by none
  • intelligence/seed/strategies.tsp is excluded by none and included by none
  • main.tsp is excluded by none and included by none
  • models/agent/agent-run.tsp is excluded by none and included by none
  • models/agent/tool-call.tsp is excluded by none and included by none
  • models/agent/workflow-checkpoint.tsp is excluded by none and included by none
  • models/agent/workflow-execution.tsp is excluded by none and included by none
  • models/db.tsp is excluded by none and included by none
  • models/deployment.tsp is excluded by none and included by none
  • models/error.tsp is excluded by none and included by none
  • models/genai.tsp is excluded by none and included by none
  • models/http.tsp is excluded by none and included by none
  • models/identity.tsp is excluded by none and included by none
  • models/log.tsp is excluded by none and included by none
  • models/messaging.tsp is excluded by none and included by none
  • models/otel-config.tsp is excluded by none and included by none
  • models/rpc.tsp is excluded by none and included by none
  • models/session.tsp is excluded by none and included by none
  • models/system.tsp is excluded by none and included by none
  • models/test.tsp is excluded by none and included by none
  • otel/enums.tsp is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4b87388a-2977-4dcf-9eb1-29af05db9bcc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Comment/doc-only sweep across the TypeSpec source tree to keep the qyl API schema’s narrative and banner text accurate (without changing schema semantics), plus removal of a stale handoff document.

Changes:

  • Removed/neutralized stale OpenTelemetry semantic convention version claims (e.g., “OTel v1.40”) in model headers and a few @doc(...) strings.
  • Deleted dead/obsolete references to non-existent files and prior PR provenance narration in comments.
  • Deleted HANDOFF.md as an outdated, pre-release operational handoff note.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
otel/enums.tsp Removes a hardcoded semconv version claim from the banner comment.
models/test.tsp Removes “(OTel v1.40)” from the header banner comment.
models/system.tsp Removes “(OTel v1.40)” from the header banner comment.
models/session.tsp Removes “(OTel v1.40)” from the header banner comment.
models/rpc.tsp Removes “(OTel v1.40)” from the header banner comment.
models/otel-config.tsp Removes “(OTel v1.40)” from the header banner comment.
models/messaging.tsp Removes “(OTel v1.40)” from the header banner comment.
models/log.tsp Removes “(OTel v1.40)” from the header banner comment.
models/identity.tsp Removes “(OTel v1.40)” from the header banner comment.
models/http.tsp Drops “Complete OTel v1.40” wording and removes versioned @doc text.
models/genai.tsp Drops “Complete OTel v1.40”/provenance phrasing and removes versioned @doc text.
models/error.tsp Removes “(OTel v1.40)” from the header banner comment.
models/deployment.tsp Removes “(OTel v1.40)” from the header banner comment.
models/db.tsp Drops “Complete OTel v1.40” wording and removes versioned @doc text.
models/agent/workflow-execution.tsp Removes “(OTel v1.40)” from the header banner comment.
models/agent/workflow-checkpoint.tsp Removes “(OTel v1.40)” from the header banner comment.
models/agent/tool-call.tsp Removes “(OTel v1.40)” from the header banner comment.
models/agent/agent-run.tsp Removes “(OTel v1.40)” from the header banner comment.
main.tsp Removes PR-provenance wording and updates “Extracted …” phrasing to local/domain wording.
intelligence/seed/strategies.tsp Removes dead references to external specs/static registries in comments.
intelligence/seed/rules.tsp Removes dead references to external specs/static registries in comments.
intelligence/seed/patterns.tsp Removes dead references to external specs/static registries while keeping seed provenance.
intelligence/main.tsp Removes a “source of truth” comment pointing at a non-existent spec file.
emit-config.tsp Removes dead references (“NamespaceRoutingTable.cs”, “Mandate §Commit-4”) from comments.
HANDOFF.md Deletes an outdated, no-longer-relevant handoff document.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ANcpLua ANcpLua merged commit 4122aee into main Jul 3, 2026
5 checks passed
@ANcpLua ANcpLua deleted the chore/comment-truth-sweep branch July 3, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants