Skip to content

chore: drop stale version anchor in otelconventions-lint registry comment#83

Merged
ANcpLua merged 1 commit into
mainfrom
chore/comment-truth-round2
Jul 3, 2026
Merged

chore: drop stale version anchor in otelconventions-lint registry comment#83
ANcpLua merged 1 commit into
mainfrom
chore/comment-truth-round2

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Comment-only. The reserved-prefix doc comment anchored itself to "registry 1.40" while the repo pin is v1.41.0. Numbers in comments drift — the pin lives in common/types.tsp — so the version anchor is deleted entirely; the maintenance instruction stays.

Verification: npm run lint (build:emitters + tsp compile --warn-as-error) — Compilation completed successfully. Complete-and-verified.

🤖 Generated with Claude Code

…omment

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 3, 2026 03:53
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • emitters/otelconventions-lint/src/registry.ts is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f34afa00-76aa-448e-954f-328f3c8db9a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR keeps the otelconventions-lint registry maintenance guidance accurate by removing a stale hard-coded semantic-convention version (“registry 1.40”) from a doc comment, relying on the repo’s actual pin instead.

Changes:

  • Removed the specific “registry 1.40” anchor from the reserved-prefixes doc comment to avoid future drift.
  • Kept the actionable maintenance instruction (“extend when Weaver advances; do not let the list drift silently”).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ANcpLua ANcpLua merged commit 9e5718f into main Jul 3, 2026
5 checks passed
@ANcpLua ANcpLua deleted the chore/comment-truth-round2 branch July 3, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants