Conditionally reduce max DRL ref MVs for speeds >= 2 - #5279
Merged
Conversation
kslu-aom
marked this pull request as draft
August 18, 2026 17:03
Contributor
Author
|
The speedup-loss tradeoff is not good after rebase due to conflicts with recently added speed features. Marked as draft. I will rework this patch. |
Contributor
|
@kslu-aom, I’ve done this before, and at that time, the tradeoff wasn’t good either. However, it appears to be acceptable after the commit of this PR, but it’s not good again on the latest ToT. |
kslu-aom
force-pushed
the
av2enc-reddrlmv
branch
from
August 21, 2026 03:30
93607d9 to
60be851
Compare
kslu-aom
marked this pull request as ready for review
August 21, 2026 03:35
kslu-aom
force-pushed
the
av2enc-reddrlmv
branch
from
August 21, 2026 03:40
60be851 to
f0ccfd9
Compare
kslu-aom
requested review from
leolzhao,
linzhen-beep,
urvangjoshi,
yeqing-wu and
yunqingwang1
August 21, 2026 03:40
Contributor
|
@kslu-aom The code change affects speed 1 as well? |
Contributor
Author
Some changes intended for speed 1 tests are included by mistake. I will update this PR later. |
kslu-aom
force-pushed
the
av2enc-reddrlmv
branch
from
August 21, 2026 20:47
4d18a58 to
9938991
Compare
Contributor
Author
|
@yunqingwang1 I have cleaned up the unintended changes. Please take another look |
yeqing-wu
approved these changes
Aug 21, 2026
yeqing-wu
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, one minor suggestion to simplify the code
yeqing-wu
enabled auto-merge (squash)
August 21, 2026 21:40
leolzhao
force-pushed
the
av2enc-reddrlmv
branch
from
August 24, 2026 16:11
35f8ec0 to
c9692e7
Compare
- Introduce the reduce_max_drl_refmvs speed feature to reduce the default DRL candidate count from 4 to 3 in higher encode speeds. - Enable frame-level DRL adaptation (allow_frame_max_drl_bits = 1) when reduce_max_drl_refmvs is active: key, boosted, and low pyramid level frames (<= 2) retain 4 candidates (max_drl_bits = 3) to retain reference quality, while leaf frames use 3 candidates (max_drl_bits = 2). - Condition newmv_drl_search_limit on reduce_max_drl_refmvs to ensure both ref_mv_idx 0 and 1 are searched before reusing results, preventing motion predictor diversity collapse. - The existing --max-drl-refmvs CLI flag continues to override this behavior.
…mit settings - Remove accidental duplicate reduce_max_drl_refmvs = 1 from speed >= 1 block (it is only enabled for speed >= 2). - Simplify newmv_drl_search_limit assignment in speed >= 1 to boosted ? 2 : 1. - In speed >= 2, directly set newmv_drl_search_limit = 2 when reduce_max_drl_refmvs is active. TAG=agy CONV=47a24228-432f-4ef3-ae5e-68f3663750dc
urvangjoshi
force-pushed
the
av2enc-reddrlmv
branch
from
August 25, 2026 15:50
c9692e7 to
d49df89
Compare
urvangjoshi
disabled auto-merge
August 25, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluation based on 2abcfff with 33 frames at speed 2: