Skip to content

Promote tx stat pruning to Speed 3 - #5282

Merged
leolzhao merged 1 commit into
AOMediaCodec:av2-encfrom
chengchen-google:0817/0001_s3_promote_tx_stat_pruning
Aug 21, 2026
Merged

Promote tx stat pruning to Speed 3#5282
leolzhao merged 1 commit into
AOMediaCodec:av2-encfrom
chengchen-google:0817/0001_s3_promote_tx_stat_pruning

Conversation

@chengchen-google

@chengchen-google chengchen-google commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Promote tx stat pruning to Speed 3
The speed feature was at speed 4.

Enabling the speed feature at speed 3 shows
encoder speed up with acceptable coding loss.

New test on top of base commit 5d628d8

Speed 3
Testset PSNR-YUV EncSpeedUp Ratio
A1 (17 frames) 0.14% 8.28% 59.1
A2 (33 frames) 0.17% 6.53% 38.4

Original test on top of base commit fe1bfde

Performance on RA speed 3
Testset PSNR-YUV EncSpeedUp
A1 (17 frames) 0.15% 6.55%
A2 (33 frames) 0.22% 5.68%

Besides, we tested the speed feature at speed 2, it does not
meet the bar for A1.

Performance on RA speed 2
Testset PSNR-YUV EncSpeedUp
A1 (17 frames) 0.16% 4.02%
A2 (33 frames) 0.13% 4.46%

STATS_CHANGED

@chengchen-google
chengchen-google force-pushed the 0817/0001_s3_promote_tx_stat_pruning branch from 0f679ee to e5ceeaf Compare August 19, 2026 17:07
@chengchen-google chengchen-google changed the title Promote tx stat pruning to Speed 3 Promote tx stat pruning to Speed 2 Aug 19, 2026
@urvangjoshi
urvangjoshi requested review from leolzhao, yeqing-wu and yunqingwang1 and removed request for urvangjoshi August 20, 2026 16:12
@leolzhao

Copy link
Copy Markdown
Contributor

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

@chengchen-google

Copy link
Copy Markdown
Contributor Author

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

@chengchen-google
chengchen-google force-pushed the 0817/0001_s3_promote_tx_stat_pruning branch from e5ceeaf to 5ca573b Compare August 20, 2026 18:28
@leolzhao

Copy link
Copy Markdown
Contributor

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

@chengchen-google

Copy link
Copy Markdown
Contributor Author

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The anchor commit is fe1bfde

@leolzhao

Copy link
Copy Markdown
Contributor

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The anchor commit is fe1bfde

Could you please test again on top of current av2-enc branch head commit 5d628d8?

@chengchen-google chengchen-google changed the title Promote tx stat pruning to Speed 2 Promote tx stat pruning to Speed 3 Aug 20, 2026
@chengchen-google

Copy link
Copy Markdown
Contributor Author

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The anchor commit is fe1bfde

Could you please test again on top of current av2-enc branch head commit 5d628d8?

Sure.

@chengchen-google

Copy link
Copy Markdown
Contributor Author

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The trade off for speed 2 A1 is less than the threshold, so suggest to move it up to speed 3 instead of 2. In addition, as the trade off for speed 3 with class A2 just pass the threshold, it would be better to check the performance with av2-enc ToT. If it's still passing 25 threshold, we can turn it on for speed 3.

Thanks for the review. I agree with only turning it on for speed 3. I will update the PR.

No problem. What's the anchor for this test?

The anchor commit is fe1bfde

Could you please test again on top of current av2-enc branch head commit 5d628d8?

The performance on speed 3 as compared to the the new anchor commit is:
Testset PSNR-YUV EncSpeedUp Ratio
A1 (17 frames) 0.14% 8.28% 59.1
A2 (33 frames) 0.17% 6.53% 38.4

@chengchen-google
chengchen-google force-pushed the 0817/0001_s3_promote_tx_stat_pruning branch from 5ca573b to e7e5a17 Compare August 21, 2026 16:56
The speed feature was at speed 4.

Enabling the speed feature at speed 3 shows
encoder speed up with acceptable coding loss.

New test on top of base commit 5d628d8

Speed 3
Testset 	PSNR-YUV   EncSpeedUp   Ratio
A1 (17 frames) 	0.14% 	    8.28% 	59.1
A2 (33 frames) 	0.17% 	    6.53% 	38.4

Original test on top of base commit fe1bfde

Performance on RA speed 3
Testset 	PSNR-YUV  EncSpeedUp
A1 (17 frames) 	0.15% 	   6.55%
A2 (33 frames) 	0.22% 	   5.68%

Besides, we tested the speed feature at speed 2, it does not
meet the bar for A1.

Performance on RA speed 2
Testset 	PSNR-YUV  EncSpeedUp
A1 (17 frames) 	0.16% 	   4.02%
A2 (33 frames) 	0.13% 	   4.46%

STATS_CHANGED

Change-Id: I137179b1c46dcab214ba4f1b6e0b289717c8972d
@leolzhao
leolzhao force-pushed the 0817/0001_s3_promote_tx_stat_pruning branch from e7e5a17 to a984f99 Compare August 21, 2026 22:26
@leolzhao
leolzhao merged commit 71f1ae3 into AOMediaCodec:av2-enc Aug 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants