Refactor rd_pick_intra_dip_sby() - #5306
Open
SamuthirikaS wants to merge 3 commits into
Open
Conversation
Author
|
@yunqingwang1 @urvangjoshi |
- Move the intra DIP ML feature tracking structure (DipMlInfo) to intra_dip.h and store it directly inside the MACROBLOCK struct. - This simplifies the function signature of rd_pick_intra_dip_sby() by removing the need to pass stack-allocated feature structure.
- Extract ML-based intra DIP pruning logic from rd_pick_intra_dip_sby() into a static helper, keep_intra_dip_mode(). - This consolidates feature collection, TFLite input setup, and threshold evaluation into a single modular function, improving code structure and readability.
- Extract init_mbmi_for_intra_dip() helper to eliminate duplicate MB_MODE_INFO reset logic. - Use an early return when keep_intra_dip_mode() fails, un-nesting the main candidate mode search loop. - Encapsulate DIP mode index calculation into a dedicated get_intra_dip_mode() inline helper. - Update function return type from int to bool. - Update comments to adhere to coding guidelines. - Use pre-increment for loops in rd_pick_intra_dip_sby_modelrd().
SamuthirikaS
force-pushed
the
dip_refactor
branch
from
August 24, 2026 12:41
d868e2d to
bca927c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.