Do not enable simple_motion_search_prune_rect - #5311
Merged
Conversation
urvangjoshi
reviewed
Aug 25, 2026
xinzhao-apple
force-pushed
the
mr/avm-bugfix2
branch
from
August 25, 2026 21:15
04dcbc2 to
b36de47
Compare
urvangjoshi
approved these changes
Aug 25, 2026
av2_simple_motion_search_prune_rect() is not implemented for the AV2 partition set and asserts "Not implemented" since e2d0566. With --disable-ml-partition-speed-features=0 the speed feature turned on, the assert was compiled out under NDEBUG, and the encoder segfaulted: av2_prune_partitions_before_search() calls the function for rectangular block sizes, where convert_bsize_to_idx() returns -1 and sms_tree is NULL because fill_sms_buf() only populates square sizes. Default configurations are bit-identical; the speed feature was already forced off there by av2_disable_ml_based_partition_sf().
urvangjoshi
force-pushed
the
mr/avm-bugfix2
branch
from
August 25, 2026 22:04
b36de47 to
9bd1653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
av2_simple_motion_search_prune_rect() is not implemented for the AV2 partition set and asserts "Not implemented" since e2d0566. With --disable-ml-partition-speed-features=0 the speed feature turned on, the assert was compiled out under NDEBUG, and the encoder segfaulted: av2_prune_partitions_before_search() calls the function for rectangular block sizes, where convert_bsize_to_idx() returns -1 and sms_tree is NULL because fill_sms_buf() only populates square sizes.
This fixes #5310.