Fix film grain OBU desync when denoising a monochrome sequence - #5318
Open
xinzhao-apple wants to merge 1 commit into
Open
Fix film grain OBU desync when denoising a monochrome sequence#5318xinzhao-apple wants to merge 1 commit into
xinzhao-apple wants to merge 1 commit into
Conversation
apply_denoise_2d() stored the noise model's grain parameters verbatim, but the model always estimates all three planes while write_fgm_obu() signals only luma when seq_params->monochrome is set. The chroma scaling points and AR coefficients were therefore written but never read back, leaving the bit reader offset so the following frame header parsed as garbage and the decoder reported "Corrupt frame detected".
xinzhao-apple
force-pushed
the
mr/avm-bugfix
branch
from
August 25, 2026 21:22
acbccbc to
e871e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_denoise_2d() stored the noise model's grain parameters verbatim, but the model always estimates all three planes while write_fgm_obu() signals only luma when seq_params->monochrome is set. The chroma scaling points and AR coefficients were therefore written but never read back, leaving the bit reader offset so the following frame header parsed as garbage and the decoder reported "Corrupt frame detected".
Fix issue #5316.