Skip to content

Avoid overwriting film_grain_params_present per frame #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
urvangjoshi merged 1 commit into from
Aug 27, 2026
+4 −3
Merged

Avoid overwriting film_grain_params_present per frame #5321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions av2/encoder/encode_strategy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,9 +1191,10 @@ int av2_encode_strategy(AV2_COMP *const cpi, size_t *const size,
adjust_frame_rate(cpi, source->ts_start, source->ts_end);
if (!frame_params.duplicate_existing_frame) {
if (cpi->film_grain_table) {
cm->seq_params.film_grain_params_present = avm_film_grain_table_lookup(
cpi->film_grain_table, *time_stamp, *time_end, 0 /* =erase */,
&cm->film_grain_params);
// film_grain_params_present is sequence level and is written once in the
// sequence header, so it must not be re-derived per frame here.
avm_film_grain_table_lookup(cpi->film_grain_table, *time_stamp, *time_end,
0 /* =erase */, &cm->film_grain_params);
}
// only one operating point supported now
const int64_t pts64 = ticks_to_timebase_units(timestamp_ratio, *time_stamp);
Expand Down