Skip to content

Remove unsafe unregistered Elo update endpoint - #397

Open
shwetd19 wants to merge 1 commit into
AOSSIE-Org:mainfrom
shwetd19:fix/remove-unsafe-elo-endpoint
Open

Remove unsafe unregistered Elo update endpoint#397
shwetd19 wants to merge 1 commit into
AOSSIE-Org:mainfrom
shwetd19:fix/remove-unsafe-elo-endpoint

Conversation

@shwetd19

@shwetd19 shwetd19 commented Aug 7, 2026

Copy link
Copy Markdown

Fixes #392

UpdateEloAfterDebate accepted client-supplied winnerId/loserId with no participation checks, letting any logged-in user set arbitrary ratings. The handler is not registered in main.go and has no frontend callers, so it is removed along with its route wrapper and the now-unused calculateEloRating helper. Ratings continue to be updated through the existing debate-result flow (services.UpdateRatings).

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@shwetd19, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5f6597d3-6c46-4582-aa47-b29e008dafc6

📥 Commits

Reviewing files that changed from the base of the PR and between 51532ff and 30ee13b.

📒 Files selected for processing (2)
  • backend/controllers/profile_controller.go
  • backend/routes/profile.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitcordapp

gitcordapp Bot commented Aug 7, 2026

Copy link
Copy Markdown

Link your account with Gitcord

Thanks for opening this PR, @shwetd19!

To receive Discord notifications and contributor tracking for this organization:

  1. Join Discord: https://discord.gg/hjUhu33uAn
  2. In Discord, run /link shwetd19
  3. Paste the verification code into your GitHub bio (or a public gist)
  4. Click Verify in Discord (or run /verify-link shwetd19)

Once linked, Gitcord can notify you about reviews, merges, and more.

Posted by Gitcord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: /profile Elo update endpoint lets any authenticated client set arbitrary users' ratings

1 participant