[MOD-14953] Add calcDistanceForQuery to IndexCalculatorInterface#1
Open
xiangze-arm wants to merge 1 commit into
Open
[MOD-14953] Add calcDistanceForQuery to IndexCalculatorInterface#1xiangze-arm wants to merge 1 commit into
xiangze-arm wants to merge 1 commit into
Conversation
Add calcDistanceForQuery() API and use it in HNSW index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This PR adds a new
calcDistanceForQueryAPI inIndexCalculatorInterfacethat lets us separate distance calculation of a query and a candidate from distance calculation of two candidates.It enables distance compute of asymmetric distances (FP32/FP16 query vs. SQ8 candidate) alongside symmetric distances(SQ8 candidate vs. SQ8 candidate).
Which issues this PR fixes
Main objects this PR modified
IndexCalculatorInterface— Add calcDistanceForQuery APIDistanceCalculatorCommon— Add common implementationHNSWIndexclasses — Change API from calcDistance to calcDistanceForQuery when it is used for query distance calculationVecSimIndexAbstractclass — Add calcDistanceForQuery API forVecSimIndexAbstractclassMark if applicable