Redesign atomic store with hints intrinsics#432
Conversation
| | -------------------- | --------- | --------------------------------------------------------------------------------- | | ||
| | KEEP | 0 | Signals to retain the updated location in the local cache of the updating PE. | | ||
| | STRM | 1 | Signals to not retain the updated location in the local cache of the updating PE. | | ||
| The fourth argument `hint` selects the requested hint. The set of valid |
There was a problem hiding this comment.
What will be the behaviour if hint is not valid?
There was a problem hiding this comment.
I guess that is undefined behaviour and will be implementation based. For LLVM we will throw error and reject.
There was a problem hiding this comment.
Should it throw an error or just ignore and still do the atomic store?
There was a problem hiding this comment.
I would throw error. This seems like a user mistake and we shouldn't just let it silently pass imo.
There was a problem hiding this comment.
I agree with throwing an error, the generic versions of these should be used when not using a hint
There was a problem hiding this comment.
Given the point of this change is to make the builtin more generic, it doesn't make sense to then add barriers to future uses. We've already said a toolchain is free to ignore the hint and that's effectively what an older toolchain should do if given a hint that only newer toolchains support. If we want to help users spot potential typos then we can add an "unknown hint will be ignored" diagnostic.
There was a problem hiding this comment.
So for the atomic_store intrinsics here, it would be fine to have them work without the hint, however, for the atomic_fetch intrinsics added in #430, the assembly output is limited to the LSE variant as the hint does not work for other variants, so outline atomics will not be used. In that case we really don't want this to be seen as an alternative to using the non-hint atomics
| | KEEP | 0 | Signals to retain the updated location in the local cache of the updating PE. | | ||
| | STRM | 1 | Signals to not retain the updated location in the local cache of the updating PE. | | ||
| The fourth argument `hint` selects the requested hint. The set of valid | ||
| hint values depends on the architectural features supported by the |
There was a problem hiding this comment.
What is the difference between Hint and hint besides the first letter being in capital or lower? Does it have different meaning for @sallyarmneale ?
|
LGTM |
This proposal is about redesigning atomic store with hint intrinsics, to make them more easily extensible.
Checklist: (mark with
Xthose which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightTextlines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019, and usecommas to separate gaps, as in
2018-2020, 2022).Copyrightsection of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversionis set totruein the YAML headerof the sources of the specifications I have modified.
in the README page of the project.