Skip to content

platform: Fixup nrf54l targets lc10a and lv10a - #427

Open
sigvartmh wants to merge 1 commit into
ARM-software:mainfrom
sigvartmh:test
Open

platform: Fixup nrf54l targets lc10a and lv10a#427
sigvartmh wants to merge 1 commit into
ARM-software:mainfrom
sigvartmh:test

Conversation

@sigvartmh

Copy link
Copy Markdown
Contributor

Change the watchdog and uart configs which are wrong.

Change the watchdog and uart configs which are wrong.

Signed-off-by: Sigvart Hovland <sigvart.hovland@nordicsemi.no>
Copilot AI lite review requested due to automatic review settings August 17, 2026 12:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the nRF54L non-secure PAL configuration to use a single UART and watchdog instance while clarifying how the watchdog instance is selected in the driver.

Changes:

  • Reduce UART configuration from an out-of-range placeholder (20) to a single instance (0)
  • Reduce watchdog configuration from a placeholder instance (4) to a single instance (0) and update explanatory comments
  • Update platform-level macro mappings to the new UART/watchdog instance macros

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +94 to +95
#define PLATFORM_WD_TIMEOUT_IN_MICRO_SEC_MEDIUM WATCHDOG_0_TIMEOUT_IN_MICRO_SEC_LOW
#define PLATFORM_WD_TIMEOUT_IN_MICRO_SEC_HIGH WATCHDOG_0_TIMEOUT_IN_MICRO_SEC_LOW
@avinaw01-arm avinaw01-arm self-assigned this Aug 18, 2026
@avinaw01-arm

Copy link
Copy Markdown
Member

Hi @sigvartmh
Thanks for raising the P.R.

I noticed that PLATFORM_WD_TIMEOUT_IN_MICRO_SEC_MEDIUM and PLATFORM_WD_TIMEOUT_IN_MICRO_SEC_HIGH are both assigned the value of PLATFORM_WD_TIMEOUT_IN_MICRO_SEC_LOW in your config file. Even if these values are currently unused on your platform, would it make sense to assign the respective timeout values to these platform macros for consistency and correctness?

Could you please take a look and let us know your thoughts? Apart from this, the rest of the P.R. looks good to me and should be fine to merge. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants