Skip to content

fix(exerciser): clear ATS TXN set after ATS is done #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
Jul 3, 2026
Merged

fix(exerciser): clear ATS TXN set after ATS is done #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pal/baremetal/base/include/pal_common_support.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,8 @@ typedef enum {
START_TXN_MONITOR = 0xb,
STOP_TXN_MONITOR = 0xc,
ATS_TXN_REQ = 0xd,
INJECT_ERROR = 0xe
ATS_TXN_CLEAR = 0xe,
INJECT_ERROR = 0xf
} EXERCISER_OPS;
/**
@brief Instance of system pmu info
Expand Down
3 changes: 2 additions & 1 deletion pal/baremetal/target/RDN2/include/pal_exerciser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ typedef enum {
START_TXN_MONITOR = 0xb,
STOP_TXN_MONITOR = 0xc,
ATS_TXN_REQ = 0xd,
INJECT_ERROR = 0xe
ATS_TXN_CLEAR = 0xe,
INJECT_ERROR = 0xf
} EXERCISER_OPS;

typedef enum {
Expand Down
5 changes: 3 additions & 2 deletions pal/baremetal/target/RDN2/include/platform_override_fvp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,8 +887,9 @@
#define RID_VALID_MASK (1ul << 31)
#define RID_VALID 1
#define RID_NOT_VALID 0
#define ATS_TRIGGER 1
#define ATS_STATUS (1ul << 7)
#define ATS_TRIGGER 1
#define ATS_TXN_CLEAR_BIT (1ul << 5)
#define ATS_STATUS (1ul << 7)
#define TXN_INVALID 0xFFFFFFFF
#define TXN_START 1
#define TXN_STOP 0
Expand Down
5 changes: 5 additions & 0 deletions pal/baremetal/target/RDN2/src/pal_exerciser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,9 +624,14 @@ uint32_t pal_exerciser_ops(EXERCISER_OPS Ops, uint64_t Param, uint32_t Bdf)
pal_mmio_write(Base + ATSCTL, ATS_TRIGGER);
return !(pal_mmio_read(Base + ATSCTL) & ATS_STATUS);

case ATS_TXN_CLEAR:
pal_mmio_write(Base + ATSCTL, ATS_TXN_CLEAR_BIT);
return 0;

case START_TXN_MONITOR:
pal_mmio_write(Base + TXN_CTRL_BASE, TXN_START);
return 0;

case STOP_TXN_MONITOR:
pal_mmio_write(Base + TXN_CTRL_BASE, TXN_STOP);
return 0;
Expand Down
3 changes: 2 additions & 1 deletion pal/baremetal/target/RDV3/include/pal_exerciser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ typedef enum {
START_TXN_MONITOR = 0xB,
STOP_TXN_MONITOR = 0xC,
ATS_TXN_REQ = 0xD,
INJECT_ERROR = 0xE
ATS_TXN_CLEAR = 0xE,
INJECT_ERROR = 0xF
} EXERCISER_OPS;

typedef enum {
Expand Down
1 change: 1 addition & 0 deletions pal/baremetal/target/RDV3/include/platform_override_fvp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,7 @@
#define RID_VALUE_MASK 0xFFFF
#define RID_VALID_MASK (1ul << 31)
#define ATS_TRIGGER 1
#define ATS_TXN_CLEAR_BIT (1ul << 5)
#define ATS_STATUS (1ul << 7)

/* Memory config */
Expand Down
5 changes: 5 additions & 0 deletions pal/baremetal/target/RDV3/src/pal_exerciser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,9 +622,14 @@ uint32_t pal_exerciser_ops(EXERCISER_OPS Ops, uint64_t Param, uint32_t Bdf)
pal_mmio_write(Base + ATSCTL, ATS_TRIGGER);
return !(pal_mmio_read(Base + ATSCTL) & ATS_STATUS);

case ATS_TXN_CLEAR:
pal_mmio_write(Base + ATSCTL, ATS_TXN_CLEAR_BIT);
return 0;

case START_TXN_MONITOR:
pal_mmio_write(Base + TXN_CTRL_BASE, TXN_START);
return 0;

case STOP_TXN_MONITOR:
pal_mmio_write(Base + TXN_CTRL_BASE, TXN_STOP);
return 0;
Expand Down
3 changes: 2 additions & 1 deletion pal/baremetal/target/RDV3CFG1/include/pal_exerciser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ typedef enum {
START_TXN_MONITOR = 0xb,
STOP_TXN_MONITOR = 0xc,
ATS_TXN_REQ = 0xd,
INJECT_ERROR = 0xe
ATS_TXN_CLEAR = 0xe,
INJECT_ERROR = 0xf
} EXERCISER_OPS;

typedef enum {
Expand Down
1 change: 1 addition & 0 deletions pal/baremetal/target/RDV3CFG1/include/platform_override_fvp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,7 @@
#define RID_VALUE_MASK 0xFFFF
#define RID_VALID_MASK (1ul << 31)
#define ATS_TRIGGER 1
#define ATS_TXN_CLEAR_BIT (1ul << 5)
#define ATS_STATUS (1ul << 7)

/* Memory config */
Expand Down
5 changes: 5 additions & 0 deletions pal/baremetal/target/RDV3CFG1/src/pal_exerciser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,9 +622,14 @@ uint32_t pal_exerciser_ops(EXERCISER_OPS Ops, uint64_t Param, uint32_t Bdf)
pal_mmio_write(Base + ATSCTL, ATS_TRIGGER);
return !(pal_mmio_read(Base + ATSCTL) & ATS_STATUS);

case ATS_TXN_CLEAR:
pal_mmio_write(Base + ATSCTL, ATS_TXN_CLEAR_BIT);
return 0;

case START_TXN_MONITOR:
pal_mmio_write(Base + TXN_CTRL_BASE, TXN_START);
return 0;

case STOP_TXN_MONITOR:
pal_mmio_write(Base + TXN_CTRL_BASE, TXN_STOP);
return 0;
Expand Down
2 changes: 2 additions & 0 deletions test_pool/exerciser/e020.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,8 @@ payload(void)
val_pgt_destroy(pgt_desc);
}

val_exerciser_ops(ATS_TXN_CLEAR, 0, instance);

if (val_pcie_find_capability(e_bdf, PCIE_ECAP, ECID_ATS, &cap_base) == PCIE_SUCCESS)
{
val_pcie_read_cfg(e_bdf, cap_base + ATS_CTRL, &reg_value);
Expand Down
27 changes: 8 additions & 19 deletions test_pool/exerciser/e040.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ run_cxl_path_ats_dma(uint32_t e_bdf)
uint64_t ttbr;
uint32_t device_id;
uint32_t its_id;
uint32_t test_status = ACS_STATUS_FAIL;
void *dram_buf_virt = NULL;
void *dram_buf_out_virt;
uint64_t dram_buf_phys;
Expand Down Expand Up @@ -222,26 +223,13 @@ run_cxl_path_ats_dma(uint32_t e_bdf)
goto test_fail;
}

if (smmu_mapped)
val_smmu_unmap(master);

if (smmu_enabled)
val_smmu_disable(master.smmu_index);

if (pgt_desc.pgt_base)
val_pgt_destroy(pgt_desc);

if (ats_enabled) {
val_pcie_read_cfg(e_bdf, cap_base + ATS_CTRL, &reg_value);
reg_value &= ATS_CACHING_DIS;
val_pcie_write_cfg(e_bdf, cap_base + ATS_CTRL, reg_value);
}

if (dram_buf_virt)
val_memory_free_pages(dram_buf_virt, TEST_DATA_NUM_PAGES);
return ACS_STATUS_PASS;
test_status = ACS_STATUS_PASS;
goto test_clean;

test_fail:
test_status = ACS_STATUS_FAIL;

test_clean:
if (smmu_mapped)
val_smmu_unmap(master);

Expand All @@ -257,9 +245,10 @@ run_cxl_path_ats_dma(uint32_t e_bdf)
val_pcie_write_cfg(e_bdf, cap_base + ATS_CTRL, reg_value);
}

val_exerciser_ops(ATS_TXN_CLEAR, 0, instance);
if (dram_buf_virt)
val_memory_free_pages(dram_buf_virt, TEST_DATA_NUM_PAGES);
return ACS_STATUS_FAIL;
return test_status;
}

static
Expand Down
3 changes: 2 additions & 1 deletion val/include/pal_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,8 @@ typedef enum {
START_TXN_MONITOR = 0xb,
STOP_TXN_MONITOR = 0xc,
ATS_TXN_REQ = 0xd,
INJECT_ERROR = 0xe
ATS_TXN_CLEAR = 0xe,
INJECT_ERROR = 0xf
} EXERCISER_OPS;

typedef enum {
Expand Down
Loading