Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff48002090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Just Player 2.1 transition build. The upstream source is fetched by | ||
| // scripts/prepare-justplus.sh immediately before Gradle is invoked in CI. | ||
| if (providers.gradleProperty("useJustPlus").orNull == "true") { |
There was a problem hiding this comment.
When v0.0.15 is tagged or the release workflow is dispatched, .github/workflows/android-release.yml still runs ./gradlew assembleRelease without preparing the upstream source or passing -PuseJustPlus=true. Because this condition excludes every Just+ module, that workflow builds and publishes the old :app APK rather than the transition application containing the new UI, bridge interop, and HEVC fallback.
Useful? React with 👍 / 👎.
| if (config.mode == BridgeMode.LOCAL || config.mode == BridgeMode.BOTH) { | ||
| LocalBridgeManager.stopDelayed() | ||
| } |
There was a problem hiding this comment.
For launches using LOCAL or BOTH, destroying the Just+ activity now schedules LocalBridgeManager to stop after five seconds. Lampa reads /state and /events after returning from the player, and the existing legacy activity deliberately leaves this process-level server running for that reason; this teardown makes the final state and event history unavailable shortly after playback closes.
Useful? React with 👍 / 👎.
| if (config.enabled && (config.mode == BridgeMode.LOCAL || config.mode == BridgeMode.BOTH)) { | ||
| val store = LocalBridgeManager.startOrReuse(config) | ||
| transports += LocalBridgeTransport(config, store) |
There was a problem hiding this comment.
When the configured local port is already occupied or otherwise cannot be bound, startOrReuse synchronously throws from ServerSocket.bind. This unguarded call runs inside attach during Just+ player initialization, so a local-bridge failure aborts the entire playback activity; the existing bridge setup catches this failure and continues playback without the unavailable transport.
Useful? React with 👍 / 👎.
1 participant
Transition DDD 0.0.15 to the Just+ v1.2.0 UI/playback stack while preserving the existing Android application identity and DDD compatibility layer.
Key points:
ddd_*query/fragment metadata andX-Lampa-DDD-*headers are filtered before media requests.just-player-v0.0.15-debug.apkfrom upstream Just+ v1.2.0 plus reproducible patches.This PR is intentionally a transition step: after it is stable, the legacy HEVC Activity fallback can be replaced with a dedicated Media3 FFmpeg video renderer.