Repository navigation
in with a number, a boolean or a bigint on the right is an error - #584
Merged
Merged
Conversation
`"a" in 5` compiled with no diagnostic and was false: the field lookup on a number found nothing. TypeScript rejects a primitive on the right of `in`; so does tslang now, at the right operand. A string on the right stays an extension (`"length" in s`, tests/00in_method_names.ts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"a" in 5compiled with no diagnostic and wasfalse: the field lookup on a number found nothing.Fix:
mlirGenInLogicrejects a number, boolean or bigint (literal or enum types included) on the right ofin, at the right operand, with TypeScript's message.Repro (
diagnostic-location/in_primitive.ts):Kept on purpose: a string on the right (
"length" in s, asserted bytests/00in_method_names.ts). TypeScript rejects it too, but the corpus treats it as an extension. Line 6 of the test must stay error-free.ctest -C Release -j 8 --timeout 300: 100% passed, 0 failed (4092 tests on this branch).🤖 Generated with Claude Code